Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(signer): removed bip39 dependency #1336

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Conversation

roxaneletourneau
Copy link
Collaborator

Bip 39 had unneeded translation files increasing the bundle size.

fix #1110

Thank you for your contribution to Taquito.

Before submitting this PR, please make sure:

  • Your code builds cleanly without any errors or warnings
  • You have added unit tests
  • You have added integration tests (if relevant/appropriate)
  • All public methods or types have TypeDoc coverage with a complete description, and ideally an @example
  • You have added or updated corresponding documentation
  • If relevant, you have written a first draft summary describing the change for inclusion in Release Notes.

Release Note Draft Snippet

If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.

Bip 39 had unneeded translation files increasing the bundle size.

fix #1110
@github-actions
Copy link

A new deploy preview is available on Netlify at https://730ff68f--tezostaquito.netlify.app

@github-actions
Copy link

New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/.

Published packages:

npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/

@codecov-commenter
Copy link

Codecov Report

Merging #1336 (cc18e36) into master (d5f06f8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1336      +/-   ##
==========================================
+ Coverage   79.42%   79.44%   +0.01%     
==========================================
  Files         187      188       +1     
  Lines        9916     9925       +9     
  Branches     2369     2371       +2     
==========================================
+ Hits         7876     7885       +9     
  Misses       2030     2030              
  Partials       10       10              
Impacted Files Coverage Δ
packages/taquito-signer/src/mnemonicToSeedSync.ts 100.00% <100.00%> (ø)
packages/taquito-signer/src/taquito-signer.ts 96.42% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5f06f8...cc18e36. Read the comment docs.

@roxaneletourneau roxaneletourneau merged commit 11290a8 into master Jan 20, 2022
@roxaneletourneau roxaneletourneau deleted the issue-1110-bip39 branch January 20, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dependencies includes bip39, which has unneeded translation files
3 participants