Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed operation Set_deposits_limit #2646

Closed
hui-an-yang opened this issue Sep 8, 2023 · 0 comments · Fixed by #2655
Closed

removed operation Set_deposits_limit #2646

hui-an-yang opened this issue Sep 8, 2023 · 0 comments · Fixed by #2655
Assignees
@hui-an-yang
Labels
oxford
Milestone
v18

Comments

@hui-an-yang
Copy link
Collaborator

Operation Set_deposits_limit removed. (MR !8831)

Taquito didn't support setDepositLimit as operation but it's in @taquito/local-forging and @taquito/rpc packages
We can clean up references of Set_deposits_limit in codebase
It's currently failing local-forging test with Set deposits limit 1000000 and Unset deposits limit 1000000
@Innkst Innkst added this to the v18 milestone Sep 11, 2023
@hui-an-yang hui-an-yang self-assigned this Sep 14, 2023
hui-an-yang added a commit that referenced this issue Sep 14, 2023
@hui-an-yang
refactor: removed set_deposit_limit in local-forger.forge() for oxford
d4cd4bc 
re #2646
@hui-an-yang hui-an-yang linked a pull request Sep 14, 2023 that will close this issue
2646 remove set deposits limit op reference #2655
Merged
9 tasks
@hui-an-yang hui-an-yang mentioned this issue Sep 18, 2023
Merged
9 tasks
hui-an-yang added a commit that referenced this issue Sep 18, 2023
@hui-an-yang
2646 remove set deposits limit op reference (#2655)
59def8f 
* refactor: removed set_deposit_limit in local-forger.forge() for oxford

re #2646

* test: updated local-forging test to be compatible both nairobi and oxford

* chore: syncing the fix of known-contract oxfordnet bug
@ac10n ac10n moved this to Done in Taquito Dev Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hui-an-yang hui-an-yang

Labels
oxford
Projects
Taquito Dev
Status: Done
Milestone
v18
Development

Successfully merging a pull request may close this issue.

2646 remove set deposits limit op reference ecadlabs/taquito
2 participants
@Innkst @hui-an-yang