Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize gas and storage estimation for manager operations #2532

Closed
hui-an-yang opened this issue Jun 16, 2023 · 0 comments · Fixed by #2812
Closed

Optimize gas and storage estimation for manager operations #2532

hui-an-yang opened this issue Jun 16, 2023 · 0 comments · Fixed by #2812
Assignees
@hui-an-yang
Labels
8 house keeping Chores related to keeping a clean codebase
Milestone
v19.1

Comments

@hui-an-yang
Copy link
Collaborator

hui-an-yang commented Jun 16, 2023 •
edited
Loading

With the Nairobi upgrade that gas costs for manager operations change, for reveal op changes per different addresses (pr #2447) and the rest of the operations is less by 10 times regardless of addresses.
Bakers are incentivized to include operations with a high fee to gas limit ratio, would be best that we can keep our gas limit estimation only slightly more than it's actual consumption.

image
@hui-an-yang hui-an-yang changed the title Optimize gas estimation for manager operations Optimize gas and storage estimation for manager operations Oct 3, 2023
@hui-an-yang hui-an-yang added this to the v17.4 milestone Oct 13, 2023
@hui-an-yang hui-an-yang self-assigned this Oct 13, 2023
@hui-an-yang hui-an-yang added the house keeping Chores related to keeping a clean codebase label Oct 13, 2023
@Innkst Innkst modified the milestones: v17.4, v17.5 Nov 15, 2023
@Innkst Innkst added the 8 label Nov 22, 2023
@Innkst Innkst modified the milestones: v17.5, v19.1 Dec 21, 2023
hui-an-yang added a commit that referenced this issue Feb 6, 2024
@hui-an-yang
refactor: storageLImit and gasLImit optimization
3262eb3 
re #2532
hui-an-yang added a commit that referenced this issue Feb 12, 2024
@hui-an-yang
perf: optimized all single manager operations
5a2743e 
re #2532
@hui-an-yang hui-an-yang linked a pull request Feb 14, 2024 that will close this issue
2532 optimize estimation for manager operations #2812
Merged
9 tasks
hui-an-yang added a commit that referenced this issue Feb 20, 2024
@hui-an-yang
2532 optimize estimation for manager operations (#2812)
c8bf8c7 
* refactor: (incompleted) slight refactoring with logging

* refactor: storageLImit and gasLImit optimization

re #2532

* fix: purged DEFAULT_FEE and DEFAULT_GAS_LIMIT and updated getRevealGasLimit ratio

* style: removed unneeded comments

* fix: increase gasLimit ratio to fix permit ci tests

* perf: optimized all single manager operations

re #2532

* fix: fine tune fee and gasLImit ratio to fix ci test fails

* refactor: refactored to use less magic number and better naming also fix ci fails

* test: updated ci assertion and deprecated old constants

* perf: replace magic number 166 with half of reveal opSize

* test: integration test estimation assertion changes

* fix: typo fix a bug

* test: updated estimation test after fixing typo bug

* test: test: updated estimation test

* feat: adding stub signature for talentNet compatibility for simulate_operation rpc

* fix: merge conflicts mistake

* refactor: address comment removed getRevealFeeInternal in favour of getRevealFee
@ac10n ac10n moved this to Done in Taquito Dev Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hui-an-yang hui-an-yang

Labels
8 house keeping Chores related to keeping a clean codebase
Projects
Taquito Dev
Status: Done
Milestone
v19.1
Development

Successfully merging a pull request may close this issue.

2532 optimize estimation for manager operations ecadlabs/taquito
2 participants
@Innkst @hui-an-yang