-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local-forging: Support new instruction LAMBDA_REC #2074
Comments
Hey team! Please add your planning poker estimate with Zenhub @dsawali @hui-an-yang @zainen |
hui-an-yang
added a commit
that referenced
this issue
Nov 28, 2022
hui-an-yang
added a commit
that referenced
this issue
Nov 29, 2022
hui-an-yang
added a commit
that referenced
this issue
Nov 29, 2022
hui-an-yang
added a commit
that referenced
this issue
Nov 30, 2022
dsawali
added a commit
that referenced
this issue
Dec 6, 2022
* 2073 support type ticket deprecated in michelson encoder (#2094) * feat: exposed setParserProvider configuration through TezosToolkit re #660 * test: added integration tests using setParserProvider with TezosToolkit re #660 * docs: updated starting production server commands with taquito-test-dapp readme.md * test: removed unnecessory console.log re #660 * chore: update vite to latest version * docs: fixed some typos in doc to address comments re #660 * 1630 ballot operation support in contract API (#2050) * added estimate and contract ballot operation support * added rpc contract provider for ballot op * updated implementation and added docs * added property in OperationContentsAndResultBallot and added unit test * remove metadata property from ballot * addressed PR comments * updated yarn and package-lock * cleaned up comments and switched out async for promise in op emitter * removed unnecessary line break * 660 support customize parser options (#2061) * feat: exposed setParserProvider configuration through TezosToolkit re #660 * test: added integration tests using setParserProvider with TezosToolkit re #660 * docs: updated starting production server commands with taquito-test-dapp readme.md * test: removed unnecessory console.log re #660 * chore: update vite to latest version * docs: fixed some typos in doc to address comments re #660 * feat(n): support type ticket_deprecated in michelson encoder re #2073 * contract-security-non-existent-KT-address: use rpc (#2091) * fix: address comment with TicketDeprecatedEncodeError and fix unit tests fix #2073 Co-authored-by: Davis Sawali <[email protected]> Co-authored-by: Arvid Jakobsson <[email protected]> Co-authored-by: Roxane Létourneau <[email protected]> * Deprecate Tezbridge (#2105) * 1630 ballot operation support in contract API (#2050) * added estimate and contract ballot operation support * added rpc contract provider for ballot op * updated implementation and added docs * added property in OperationContentsAndResultBallot and added unit test * remove metadata property from ballot * addressed PR comments * updated yarn and package-lock * cleaned up comments and switched out async for promise in op emitter * removed unnecessary line break * 660 support customize parser options (#2061) * feat: exposed setParserProvider configuration through TezosToolkit re #660 * test: added integration tests using setParserProvider with TezosToolkit re #660 * docs: updated starting production server commands with taquito-test-dapp readme.md * test: removed unnecessory console.log re #660 * chore: update vite to latest version * docs: fixed some typos in doc to address comments re #660 * refactor: deprecate tezbridge and related * contract-security-non-existent-KT-address: use rpc (#2091) * refactor: deprecate tezbridge and related Co-authored-by: Davis Sawali <[email protected]> Co-authored-by: hui-an-yang <[email protected]> Co-authored-by: Arvid Jakobsson <[email protected]> Co-authored-by: Roxane Létourneau <[email protected]> * 2064 lima integration remove jakarta (#2084) * 1630 ballot operation support in contract API (#2050) * added estimate and contract ballot operation support * added rpc contract provider for ballot op * updated implementation and added docs * added property in OperationContentsAndResultBallot and added unit test * remove metadata property from ballot * addressed PR comments * updated yarn and package-lock * cleaned up comments and switched out async for promise in op emitter * removed unnecessary line break * 660 support customize parser options (#2061) * feat: exposed setParserProvider configuration through TezosToolkit re #660 * test: added integration tests using setParserProvider with TezosToolkit re #660 * docs: updated starting production server commands with taquito-test-dapp readme.md * test: removed unnecessory console.log re #660 * chore: update vite to latest version * docs: fixed some typos in doc to address comments re #660 * initial changes, check chainids adjust config, run originate contracts add untracked fix improper config data switch jakarta tests, switch rpc endpoint fix missed jakartanet adjust constants lima, estimate test values fix broken value * change test protocol runs Co-authored-by: Davis Sawali <[email protected]> Co-authored-by: hui-an-yang <[email protected]> Co-authored-by: Zainen Suzuki <[email protected]> * 2069 type changes (#2114) * updated types for lima * update constants.ts with protocol hash for lima * updated unit tests * changed test name for clarity * addressed PR comments * 2066 support types for new operations in lima (#2097) * feat: support new types for new operations UpdateConsensusKey and DrainDelegate in Lima re #2066 * test: update_consensus_key unit test added for limanet re #2066 * test: added drain_deleagte unit test for limanet re #2066 * test: minor fix rpc-response data and updateConsensusKey unit test re #2066 * test: addressed comments to update correct test title re #2066 * Replace lima rpc url in test * added new rpc endpoints and updated tests (#2148) * added new rpc endpoints and updated tests * updated unit tests * updated unit test for rpc-cache * updated typedoc and updated test to originate own contract * 2065 local forging support new operations for lima 2 (#2139) * feat: support new types for new operations UpdateConsensusKey and DrainDelegate in Lima re #2066 * test: update_consensus_key unit test added for limanet re #2066 * feat: support new operation UpdateConsensusKey for Lima re #2065 * feat: support new operation updateConsensusKey in local-forger for Lima re #2065 * revert: removed unnecesorry change of updateConsensusKey in rpc-batch-provider re #2065 * revert: changes of update_consensus_key in RpcContractProvider and RPCEstimateProvider re #2065 * feat: support new operation drainDelegate for Lima re #2065 * feat: support new encoding for ticket & ticket depreacted in lima with tests re #2072 * fix: added ASSERT_SOME in ticketCode and fixed 2 integration tests in lima re #2072 * fix: fixs merge conflicts * fix: replaced ASSERT_SOME with its expansion in ticketCode re #2072 * test: added local-forgin integration tests for new operations re #2065 * fix: address comments removed duplicate tests and move kathcases to commoncases re #2065 * fix: address comments to remove kathcases integration tests re #2065 * test: address comments add forge and parse operation test suite back with lima cases re #2065 * test: addressing comments updated file name and added simicolons re #2065 * test: address comments added semicolon re #2065 * fix: configure localforger with lima protocol hash with lima cases re #2065 * fix: removed update_consensus_key & drain_delegate from encodersProto14 and decoderProto14 re #2065 * feat: removed Jakarta conditions in on chain view related files (#2138) re #2098 * fix(local-forging): fix encoding for deposit entrypoint (#2160) * fix(local-forging): fix encoding for deposit entrypoint In lima protocol, the %deposit entrypoint is now represented by 0x05 fix #2158 * Fix unit tests * Fix tests kathmandunet * 2071 lima rpc changes (#2095) * initial changes, check chainids adjust config, run originate contracts add untracked fix improper config data switch jakarta tests, switch rpc endpoint fix missed jakartanet adjust constants lima, estimate test values fix broken value fix constants test add minimum_stake to replace tokens_per_roll fix ticket_token type fix constants expects correct ticket updates type, todo add test corrections, add proto015 mock data add sample && unit test for ticket_updates * resolve error for test * fix tests improper values * pr comments so far * update tests for all testnets * missed test cahnge * remove yarn lock, fix missed spot * remove quotes * initial changes, check chainids adjust config, run originate contracts add untracked fix improper config data switch jakarta tests, switch rpc endpoint fix missed jakartanet adjust constants lima, estimate test values fix broken value fix constants test add minimum_stake to replace tokens_per_roll fix ticket_token type fix constants expects correct ticket updates type, todo add test corrections, add proto015 mock data add sample && unit test for ticket_updates resolve error for test fix tests improper values pr comments so far update tests for all testnets missed test cahnge remove yarn lock, fix missed spot remove quotes pr comments * fix ticket_receipt * remove duplication after mondaynet removal from tx-rollup test * fix rebase change Co-authored-by: Zainen Suzuki <[email protected]> Co-authored-by: Zainen Suzuki <[email protected]> * fix(integration-tests): fix tests for lima * test(integration-test): fix contract-tx-rollup-origination-operation test for flextesa Bump storage_limit because the constant tx_rollup_origination_size is set to an higher value on flextesa than on the testnets * test(michel-codec): added lima contracts for unit tests There is no code change in the branch. I removed the contracts related to protocols 10 to 13 and added contracts for the protocol 15. Some contracts are commented out in the contract_015.spec.ts file as they are currently failing. Those contracts should be uncommented and fixed when working on the issue #2075. re $2075 * 2074 local forging support new instruction lambda rec (#2159) * test: added code_with_lambda_rec file and test against rpc forger re #2074 * fix: added LAMBDA_REC condition padding in primEncoder and primDecoder re #2074 * style: linted lambdaRecCode re #2074 * test(integration-test): lambda_rec Deploy a contract written in plain michelson that contains the LAMBDA_REC instruction (test michel-codec and local-forging support of LAMBDA_REC inst). Call a contract having the type lambda in its entrypoint by passing a recursive lambda (test michelson-encoder package and local-forging package). * test(integration-test): fixed tx-rollup-l2-address test for limanet (#2171) * test(integration-test): fixed tx-rollup-l2-address test for limanet For the lima protocol, the instruction TICKET needs to be followed by ASSERT_SOME fix #2170 * Removed console.log * fix(rpc): add missing properties related to lima fix #2172 * add tests for parsing mode for all testnets, and fail case (#2184) * add tests for parsing mode for all testnets, and fail case * one more test fail * format Co-authored-by: Zainen Suzuki <[email protected]> * test(integration-test): small clean up and remove duplication * 2075 lambda rec michel codec (#2175) * parent 8922de6 author Zainen Suzuki <[email protected]> 1666748308 -0700 committer Zainen Suzuki <[email protected]> 1670007819 -0800 initial changes, check chainids adjust config, run originate contracts add untracked fix improper config data switch jakarta tests, switch rpc endpoint fix missed jakartanet adjust constants lima, estimate test values fix broken value fix constants test add minimum_stake to replace tokens_per_roll fix ticket_token type fix constants expects correct ticket updates type, todo add test corrections, add proto015 mock data add sample && unit test for ticket_updates fix tests improper values update tests for all testnets missed test cahnge initial work retstack still broken passing without validation add other contract add contracts and setup comment out all test passing. binanry.spec.ts failing values fix binary array sensitive order remove unneeded more cleanup Lambda_rec michelsonData addition remove duplicate change to instructionlist * feat(michel-codec): pack/unpack Lambda_rec data fix #2181 * remove commented Co-authored-by: Zainen Suzuki <[email protected]> Co-authored-by: roxaneletourneau <[email protected]> * Try fix test * Implemented update_consensus_key support in Contract API (#2179) * Implemented update_consensus_key support in Contract API and updated tests * addressed PR comments * chore(releng) bump version to 15.0.0-beta-RC.0 * remove accidental push * revert sidebar * Consensus key docs (#2205) * added updated_consensus_key op docs * fixed typos in doc * chore(releng) bump version to 15.0.0 Co-authored-by: hui-an-yang <[email protected]> Co-authored-by: Davis Sawali <[email protected]> Co-authored-by: Arvid Jakobsson <[email protected]> Co-authored-by: Edward Garson <[email protected]> Co-authored-by: Zainen <[email protected]> Co-authored-by: Zainen Suzuki <[email protected]> Co-authored-by: Zainen Suzuki <[email protected]>
hui-an-yang
added a commit
that referenced
this issue
Dec 15, 2022
* 2073 support type ticket deprecated in michelson encoder (#2094) * feat: exposed setParserProvider configuration through TezosToolkit re #660 * test: added integration tests using setParserProvider with TezosToolkit re #660 * docs: updated starting production server commands with taquito-test-dapp readme.md * test: removed unnecessory console.log re #660 * chore: update vite to latest version * docs: fixed some typos in doc to address comments re #660 * 1630 ballot operation support in contract API (#2050) * added estimate and contract ballot operation support * added rpc contract provider for ballot op * updated implementation and added docs * added property in OperationContentsAndResultBallot and added unit test * remove metadata property from ballot * addressed PR comments * updated yarn and package-lock * cleaned up comments and switched out async for promise in op emitter * removed unnecessary line break * 660 support customize parser options (#2061) * feat: exposed setParserProvider configuration through TezosToolkit re #660 * test: added integration tests using setParserProvider with TezosToolkit re #660 * docs: updated starting production server commands with taquito-test-dapp readme.md * test: removed unnecessory console.log re #660 * chore: update vite to latest version * docs: fixed some typos in doc to address comments re #660 * feat(n): support type ticket_deprecated in michelson encoder re #2073 * contract-security-non-existent-KT-address: use rpc (#2091) * fix: address comment with TicketDeprecatedEncodeError and fix unit tests fix #2073 Co-authored-by: Davis Sawali <[email protected]> Co-authored-by: Arvid Jakobsson <[email protected]> Co-authored-by: Roxane Létourneau <[email protected]> * Deprecate Tezbridge (#2105) * 1630 ballot operation support in contract API (#2050) * added estimate and contract ballot operation support * added rpc contract provider for ballot op * updated implementation and added docs * added property in OperationContentsAndResultBallot and added unit test * remove metadata property from ballot * addressed PR comments * updated yarn and package-lock * cleaned up comments and switched out async for promise in op emitter * removed unnecessary line break * 660 support customize parser options (#2061) * feat: exposed setParserProvider configuration through TezosToolkit re #660 * test: added integration tests using setParserProvider with TezosToolkit re #660 * docs: updated starting production server commands with taquito-test-dapp readme.md * test: removed unnecessory console.log re #660 * chore: update vite to latest version * docs: fixed some typos in doc to address comments re #660 * refactor: deprecate tezbridge and related * contract-security-non-existent-KT-address: use rpc (#2091) * refactor: deprecate tezbridge and related Co-authored-by: Davis Sawali <[email protected]> Co-authored-by: hui-an-yang <[email protected]> Co-authored-by: Arvid Jakobsson <[email protected]> Co-authored-by: Roxane Létourneau <[email protected]> * 2064 lima integration remove jakarta (#2084) * 1630 ballot operation support in contract API (#2050) * added estimate and contract ballot operation support * added rpc contract provider for ballot op * updated implementation and added docs * added property in OperationContentsAndResultBallot and added unit test * remove metadata property from ballot * addressed PR comments * updated yarn and package-lock * cleaned up comments and switched out async for promise in op emitter * removed unnecessary line break * 660 support customize parser options (#2061) * feat: exposed setParserProvider configuration through TezosToolkit re #660 * test: added integration tests using setParserProvider with TezosToolkit re #660 * docs: updated starting production server commands with taquito-test-dapp readme.md * test: removed unnecessory console.log re #660 * chore: update vite to latest version * docs: fixed some typos in doc to address comments re #660 * initial changes, check chainids adjust config, run originate contracts add untracked fix improper config data switch jakarta tests, switch rpc endpoint fix missed jakartanet adjust constants lima, estimate test values fix broken value * change test protocol runs Co-authored-by: Davis Sawali <[email protected]> Co-authored-by: hui-an-yang <[email protected]> Co-authored-by: Zainen Suzuki <[email protected]> * 2069 type changes (#2114) * updated types for lima * update constants.ts with protocol hash for lima * updated unit tests * changed test name for clarity * addressed PR comments * 2066 support types for new operations in lima (#2097) * feat: support new types for new operations UpdateConsensusKey and DrainDelegate in Lima re #2066 * test: update_consensus_key unit test added for limanet re #2066 * test: added drain_deleagte unit test for limanet re #2066 * test: minor fix rpc-response data and updateConsensusKey unit test re #2066 * test: addressed comments to update correct test title re #2066 * Replace lima rpc url in test * added new rpc endpoints and updated tests (#2148) * added new rpc endpoints and updated tests * updated unit tests * updated unit test for rpc-cache * updated typedoc and updated test to originate own contract * 2065 local forging support new operations for lima 2 (#2139) * feat: support new types for new operations UpdateConsensusKey and DrainDelegate in Lima re #2066 * test: update_consensus_key unit test added for limanet re #2066 * feat: support new operation UpdateConsensusKey for Lima re #2065 * feat: support new operation updateConsensusKey in local-forger for Lima re #2065 * revert: removed unnecesorry change of updateConsensusKey in rpc-batch-provider re #2065 * revert: changes of update_consensus_key in RpcContractProvider and RPCEstimateProvider re #2065 * feat: support new operation drainDelegate for Lima re #2065 * feat: support new encoding for ticket & ticket depreacted in lima with tests re #2072 * fix: added ASSERT_SOME in ticketCode and fixed 2 integration tests in lima re #2072 * fix: fixs merge conflicts * fix: replaced ASSERT_SOME with its expansion in ticketCode re #2072 * test: added local-forgin integration tests for new operations re #2065 * fix: address comments removed duplicate tests and move kathcases to commoncases re #2065 * fix: address comments to remove kathcases integration tests re #2065 * test: address comments add forge and parse operation test suite back with lima cases re #2065 * test: addressing comments updated file name and added simicolons re #2065 * test: address comments added semicolon re #2065 * fix: configure localforger with lima protocol hash with lima cases re #2065 * fix: removed update_consensus_key & drain_delegate from encodersProto14 and decoderProto14 re #2065 * feat: removed Jakarta conditions in on chain view related files (#2138) re #2098 * fix(local-forging): fix encoding for deposit entrypoint (#2160) * fix(local-forging): fix encoding for deposit entrypoint In lima protocol, the %deposit entrypoint is now represented by 0x05 fix #2158 * Fix unit tests * Fix tests kathmandunet * 2071 lima rpc changes (#2095) * initial changes, check chainids adjust config, run originate contracts add untracked fix improper config data switch jakarta tests, switch rpc endpoint fix missed jakartanet adjust constants lima, estimate test values fix broken value fix constants test add minimum_stake to replace tokens_per_roll fix ticket_token type fix constants expects correct ticket updates type, todo add test corrections, add proto015 mock data add sample && unit test for ticket_updates * resolve error for test * fix tests improper values * pr comments so far * update tests for all testnets * missed test cahnge * remove yarn lock, fix missed spot * remove quotes * initial changes, check chainids adjust config, run originate contracts add untracked fix improper config data switch jakarta tests, switch rpc endpoint fix missed jakartanet adjust constants lima, estimate test values fix broken value fix constants test add minimum_stake to replace tokens_per_roll fix ticket_token type fix constants expects correct ticket updates type, todo add test corrections, add proto015 mock data add sample && unit test for ticket_updates resolve error for test fix tests improper values pr comments so far update tests for all testnets missed test cahnge remove yarn lock, fix missed spot remove quotes pr comments * fix ticket_receipt * remove duplication after mondaynet removal from tx-rollup test * fix rebase change Co-authored-by: Zainen Suzuki <[email protected]> Co-authored-by: Zainen Suzuki <[email protected]> * fix(integration-tests): fix tests for lima * test(integration-test): fix contract-tx-rollup-origination-operation test for flextesa Bump storage_limit because the constant tx_rollup_origination_size is set to an higher value on flextesa than on the testnets * test(michel-codec): added lima contracts for unit tests There is no code change in the branch. I removed the contracts related to protocols 10 to 13 and added contracts for the protocol 15. Some contracts are commented out in the contract_015.spec.ts file as they are currently failing. Those contracts should be uncommented and fixed when working on the issue #2075. re $2075 * 2074 local forging support new instruction lambda rec (#2159) * test: added code_with_lambda_rec file and test against rpc forger re #2074 * fix: added LAMBDA_REC condition padding in primEncoder and primDecoder re #2074 * style: linted lambdaRecCode re #2074 * test(integration-test): lambda_rec Deploy a contract written in plain michelson that contains the LAMBDA_REC instruction (test michel-codec and local-forging support of LAMBDA_REC inst). Call a contract having the type lambda in its entrypoint by passing a recursive lambda (test michelson-encoder package and local-forging package). * feat: support drain_delegate operation in contract api re #2068 * fix: fix drain_delegate bugs in contract api re #2068 * test: added unit test for drain_delegate in contract api re #2068 * test(integration-test): fixed tx-rollup-l2-address test for limanet (#2171) * test(integration-test): fixed tx-rollup-l2-address test for limanet For the lima protocol, the instruction TICKET needs to be followed by ASSERT_SOME fix #2170 * Removed console.log * fix(rpc): add missing properties related to lima fix #2172 * add tests for parsing mode for all testnets, and fail case (#2184) * add tests for parsing mode for all testnets, and fail case * one more test fail * format Co-authored-by: Zainen Suzuki <[email protected]> * test(integration-test): small clean up and remove duplication * 2075 lambda rec michel codec (#2175) * parent 8922de6 author Zainen Suzuki <[email protected]> 1666748308 -0700 committer Zainen Suzuki <[email protected]> 1670007819 -0800 initial changes, check chainids adjust config, run originate contracts add untracked fix improper config data switch jakarta tests, switch rpc endpoint fix missed jakartanet adjust constants lima, estimate test values fix broken value fix constants test add minimum_stake to replace tokens_per_roll fix ticket_token type fix constants expects correct ticket updates type, todo add test corrections, add proto015 mock data add sample && unit test for ticket_updates fix tests improper values update tests for all testnets missed test cahnge initial work retstack still broken passing without validation add other contract add contracts and setup comment out all test passing. binanry.spec.ts failing values fix binary array sensitive order remove unneeded more cleanup Lambda_rec michelsonData addition remove duplicate change to instructionlist * feat(michel-codec): pack/unpack Lambda_rec data fix #2181 * remove commented Co-authored-by: Zainen Suzuki <[email protected]> Co-authored-by: roxaneletourneau <[email protected]> * Try fix test * Implemented update_consensus_key support in Contract API (#2179) * Implemented update_consensus_key support in Contract API and updated tests * addressed PR comments * chore(releng) bump version to 15.0.0-beta-RC.0 * test: added integraiton test of drain_delegate re #2068 * Adapt integration tests to limanet box * Missing flextesa mini-net command * docs: added documentation for drain delegate operation re #2068 * docs: updated docs * build: fixs docker command for flextesa-lima * docs: added docs for drain delegate op re #2068 * build: fixs docker command for flextesa-lima * build: fixs docker command for flextesa-lima * test: updated working drain delegate integration test re #2068 * test: updated sandbox file names in integration tests re #2068 * docs: removed duplicate doc re #2068 * chore: removed unused package-lock.json re #2068 * build: fixs flextesa-lima ci command * build: removed uneeded bit re #2068 * chore: removed extra sandbox-env file * chore: revert the last change * test: updated rpc check to be localhost * fix: addressed pr comments and update testdapp to reasonable gaslimit re #2068 * pull master changes * fix: address comments and add skip test condition based on protocol re #2068 * style: address comment to be consistent wtih camel case re #2068 Co-authored-by: Davis Sawali <[email protected]> Co-authored-by: Arvid Jakobsson <[email protected]> Co-authored-by: Roxane Létourneau <[email protected]> Co-authored-by: Edward Garson <[email protected]> Co-authored-by: Zainen <[email protected]> Co-authored-by: Zainen Suzuki <[email protected]> Co-authored-by: roxaneletourneau <[email protected]> Co-authored-by: Zainen Suzuki <[email protected]> Co-authored-by: Daniele Lisi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem and use case? Please describe.
Add support for the
LAMBDA_REC
instruction in the local Forger.Describe the solution you'd like
To do so, add the
LAMBDA_REC
instruction to theopMapping
constant: https://github.com/ecadlabs/taquito/blob/master/packages/taquito-local-forging/src/constants.ts#L53Add a test to forge/unforge a contract origination containing the instruction LAMBDA_REC
Contract examples:
Additional context
https://tezos.gitlab.io/protocols/015_lima.html#minor-changes
The text was updated successfully, but these errors were encountered: