Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hard-coded values should be internationalized (public front end web app) #112

Closed
heidivanparys opened this issue Dec 6, 2021 · 0 comments
Closed

Hard-coded values should be internationalized (public front end web app) #112

heidivanparys opened this issue Dec 6, 2021 · 0 comments
Labels
solved Solution developed and accepted, not yet deployed Type: Enhancement New feature or request
Milestone
v2.4.0

Comments

@heidivanparys
Copy link
Contributor

“Refine results” and “Clear all” in the search page of the public front end web app should be internationalized:

image

re3gistry/dist/webapp/public_html/search.html

Line 183 in 79f8060

<span class="ecl-button__container"><span class="ecl-button__label" data-ecl-label="true">Refine results</span></span>

re3gistry/dist/webapp/public_html/search.html

Line 188 in 79f8060

<span class="ecl-button__container"><span class="ecl-button__label" data-ecl-label="true">Clear all</span></span>

@emanuelaepure10 emanuelaepure10 added the Type: Enhancement New feature or request label Mar 30, 2022
unaibrrgn added a commit that referenced this issue Jul 11, 2022
@unaibrrgn
Values internationalized in frontend #112
68ed06a 
Added the code value to all the languages.
@oscar9 oscar9 added the ready for testing Solution is ready to test label Jul 11, 2022
@oscar9 oscar9 added this to the v2.4.0 milestone Oct 4, 2022
unaibrrgn added a commit that referenced this issue Oct 5, 2022
@unaibrrgn
Issue now solved in serviceWebapp instead of dist/webapp #112
823e904
@oscar9 oscar9 added solved Solution developed and accepted, not yet deployed and removed ready for testing Solution is ready to test labels Oct 18, 2022
@oscar9 oscar9 closed this as completed Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
solved Solution developed and accepted, not yet deployed Type: Enhancement New feature or request
Projects
None yet
Milestone
v2.4.0
Development

No branches or pull requests
4 participants
@oscar9 @heidivanparys @emanuelaepure10 @unaibrrgn