Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

ISAICP-6787: Optimize Homepage's CSS #2649

Closed
wants to merge 3 commits into from
Closed

Conversation

theosuja
Copy link

@theosuja theosuja commented Nov 3, 2021

No description provided.

@theosuja theosuja requested review from pfrenssen and gingapa November 3, 2021 08:46
@theosuja
Copy link
Author

theosuja commented Nov 3, 2021

I'd need functional team's help for:

  • add "btn btn-secondary" to the button of the "Highlighted event" (since i can't see that content on HP)
  • add "btn btn-secondary" to the "Read more" buttons at the bottom of each card in Explore block (first tab is already working, but I can't figure out how to do it on the other ones)

cc @pfrenssen

@theosuja
Copy link
Author

theosuja commented Nov 3, 2021

Note: The !optional statements on _global-search-block.scss must be removed, but this will be handled once this PR is merged with #2633 which modifies that same file. There will be merge conflicts in which we must keep #2633 's changes
image

Copy link

@gingapa gingapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, well done!

@pfrenssen
Copy link
Contributor

Looking good but we have moved in the meantime to Gitlab. Closing in favor of https://git.fpfis.eu/digit/digit-joinup-dev/-/merge_requests/43

@pfrenssen pfrenssen closed this Nov 4, 2021
@pfrenssen pfrenssen deleted the ISAICP-6787 branch November 4, 2021 09:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants