This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
Revert "Revert "ISAICP-6729: Change search block in homepage."" #2636
Open
pfrenssen
wants to merge
7
commits into
EPIC-6572
Choose a base branch
from
revert-2634-revert-2625-ISAICP-6729
base: EPIC-6572
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+194
−12
Open
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
81cb9fb
Revert "Revert "ISAICP-6729: Change search block in homepage.""
pfrenssen 4fa9ffb
Merge remote-tracking branch 'origin/EPIC-6572' into revert-2634-reve…
idimopoulos d09d20b
ISAICP-6729: There is no more a search field in the exposed filters.
idimopoulos 06a7596
ISAICP-6729: Fix search alter Search page.
saidatom bf27861
Merge remote-tracking branch 'origin/EPIC-6572' into revert-2634-reve…
saidatom 28a4b7e
Merge remote-tracking branch 'origin/EPIC-6572' into revert-2634-reve…
saidatom 3346752
ISAICP-6729: Missing selector Search field.
saidatom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
20 changes: 11 additions & 9 deletions
20
config/sync/block.block.globalsearch.yml → config/sync/block.block.exposed_search.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
web/themes/ventuno/templates/block/block--exposed-search.html.twig
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
{# | ||
/** | ||
* @file | ||
* Default theme implementation for the global search bar. | ||
* | ||
* Available variables: | ||
* - filters: the search filters, to be displayed as chips. | ||
* | ||
* @ingroup themeable | ||
*/ | ||
#} | ||
{% | ||
set search_url = path('view.search.page_1') | ||
%} | ||
<h2 class="display-6 mb-4 text-center text-lg-start">{{ 'Find the <strong>interoperability<br>resources</strong> you need'|trans }}</h2> | ||
{% block content %} | ||
<div class="search-bar mb-3"> | ||
{{ content }} | ||
</div> | ||
{% endblock %} | ||
<p class="text-center text-lg-start">{% trans %}<span class="d-block d-lg-inline">Need more search options?</span> <span class="d-block d-lg-inline">Use our <a class="text-primary text-decoration-underline" href="{{ search_url }}">advanced search</a></span>{% endtrans %}</p> |
102 changes: 102 additions & 0 deletions
102
web/themes/ventuno/templates/form/form-element--views-exposed-form-search.html.twig
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,102 @@ | ||
{# | ||
/** | ||
* @file | ||
* Default theme implementation for a form element views exposed form search block. | ||
* | ||
* Available variables: | ||
* - attributes: HTML attributes for the containing element. | ||
* - errors: (optional) Any errors for this form element, may not be set. | ||
* - prefix: (optional) The form element prefix, may not be set. | ||
* - suffix: (optional) The form element suffix, may not be set. | ||
* - required: The required marker, or empty if the associated form element is | ||
* not required. | ||
* - type: The type of the element. | ||
* - name: The name of the element. | ||
* - label: A rendered label element. | ||
* - label_display: Label display setting. It can have these values: | ||
* - before: The label is output before the element. This is the default. | ||
* The label includes the #title and the required marker, if #required. | ||
* - after: The label is output after the element. For example, this is used | ||
* for radio and checkbox #type elements. If the #title is empty but the | ||
* field is #required, the label will contain only the required marker. | ||
* - invisible: Labels are critical for screen readers to enable them to | ||
* properly navigate through forms but can be visually distracting. This | ||
* property hides the label for everyone except screen readers. | ||
* - attribute: Set the title attribute on the element to create a tooltip but | ||
* output no label element. This is supported only for checkboxes and radios | ||
* in \Drupal\Core\Render\Element\CompositeFormElementTrait::preRenderCompositeFormElement(). | ||
* It is used where a visual label is not needed, such as a table of | ||
* checkboxes where the row and column provide the context. The tooltip will | ||
* include the title and required marker. | ||
* - description: (optional) A list of description properties containing: | ||
* - content: A description of the form element, may not be set. | ||
* - attributes: (optional) A list of HTML attributes to apply to the | ||
* description content wrapper. Will only be set when description is set. | ||
* - description_display: Description display setting. It can have these values: | ||
* - before: The description is output before the element. | ||
* - after: The description is output after the element. This is the default | ||
* value. | ||
* - invisible: The description is output after the element, hidden visually | ||
* but available to screen readers. | ||
* - disabled: True if the element is disabled. | ||
* - title_display: Title display setting. | ||
* | ||
* @see template_preprocess_form_element() | ||
* | ||
* @ingroup themeable | ||
*/ | ||
#} | ||
{% | ||
set classes = [ | ||
'input-group', | ||
'js-form-item', | ||
'form-item', | ||
'js-form-type-' ~ type|clean_class, | ||
'form-item-' ~ name|clean_class, | ||
'js-form-item-' ~ name|clean_class, | ||
title_display not in ['after', 'before'] ? 'form-no-label', | ||
disabled == 'disabled' ? 'form-disabled', | ||
errors ? 'form-item--error', | ||
col_class ? col_class, | ||
margin_class ? margin_class, | ||
] | ||
%} | ||
{% | ||
set description_classes = [ | ||
'description', | ||
'form-text', | ||
'text-muted', | ||
description_display == 'invisible' ? 'visually-hidden', | ||
] | ||
%} | ||
<div{{ attributes.addClass(classes) }}> | ||
{% if label_display in ['before', 'invisible'] %} | ||
{{ label }} | ||
{% endif %} | ||
{% if prefix is not empty %} | ||
<span class="field-prefix">{{ prefix }}</span> | ||
{% endif %} | ||
{% if description_display == 'before' and description.content %} | ||
<small{{ description.attributes }}> | ||
{{ description.content }} | ||
</small> | ||
{% endif %} | ||
{{ children }} | ||
{% if suffix is not empty %} | ||
<span class="field-suffix">{{ suffix }}</span> | ||
{% endif %} | ||
{% if label_display == 'after' %} | ||
{{ label }} | ||
{% endif %} | ||
{% if errors %} | ||
<div class="form-item--error-message invalid-feedback d-block"> | ||
{{ errors }} | ||
</div> | ||
{% endif %} | ||
{% if description_display in ['after', 'invisible'] and description.content %} | ||
<small{{ description.attributes.addClass(description_classes) }}> | ||
{{ description.content }} | ||
</small> | ||
{% endif %} | ||
<button type="submit" class="btn btn-primary btn-search shadow"><span class="d-none d-lg-inline ms-lg-3">{{ 'Search'|trans }}</span></button> | ||
</div> |
24 changes: 24 additions & 0 deletions
24
web/themes/ventuno/templates/form/input--search-expose-form.html.twig
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
{# | ||
/** | ||
* @file | ||
* Theme override for an 'input' #type form element. | ||
* | ||
* Available variables: | ||
* - attributes: A list of HTML attributes for the input element. | ||
* - children: Optional additional rendered elements. | ||
* | ||
* @see template_preprocess_input() | ||
*/ | ||
#} | ||
{% | ||
set classes = [ | ||
'search-bar__input', | ||
'form-control', | ||
'px-4', | ||
'py-3', | ||
'shadow', | ||
attributes.hasClass('error') ? 'is-invalid', | ||
] | ||
%} | ||
|
||
<input{{ attributes.addClass(classes).removeClass('form-text') }} />{{ children }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is hiding the sort also in the search. This should be conditional I guess.