This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
ISAICP-6765: “Highlighted Solution” will become “Highlighted Content”. #2631
Open
saidatom
wants to merge
19
commits into
ISAICP-6415
Choose a base branch
from
ISAICP-6765
base: ISAICP-6415
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfrenssen
suggested changes
Oct 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There has been a mistake in the implementation, the ticket requests content to be selected, but this was implemented using collections.
web/themes/ventuno/templates/rdf-entity/rdf-entity--collection--highlighted.html.twig
Outdated
Show resolved
Hide resolved
Let's also make sure that the entity queue only accepts nodes of types |
pfrenssen
suggested changes
Oct 26, 2021
web/themes/ventuno/templates/content/node--document--highlighted.html.twig
Outdated
Show resolved
Hide resolved
web/themes/ventuno/templates/content/node--event--highlighted.html.twig
Outdated
Show resolved
Hide resolved
config/sync/core.entity_view_display.node.event.highlighted.yml
Outdated
Show resolved
Hide resolved
…ed content' entity queue to access the curated content listings.
…efore displaying to the end user.
…king community content instead of solutions.
…and robust way by leveraging bundle class methods.
pfrenssen
reviewed
Oct 28, 2021
config/sync/core.entity_view_display.rdf_entity.solution.highlighted.yml
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.