Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

ISAICP-6521: Longer glossary terms conflict with substrings. #2513

Merged
merged 5 commits into from
Jul 13, 2021

Conversation

idimopoulos
Copy link
Contributor

No description provided.

@idimopoulos idimopoulos changed the title ISAICP-6521: Update the test for the similar glossary terms. ISAICP-6521: Longer glossary terms get overridden. Jul 6, 2021
@idimopoulos idimopoulos changed the title ISAICP-6521: Longer glossary terms get overridden. ISAICP-6521: Longer glossary terms conflict with substrings. Jul 6, 2021
Copy link
Contributor

@pfrenssen pfrenssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test doesn't seem to prove the bug. It is passing also if I revert the fix.

And I should see the link "BATTLE"
And I should see the link "Evermore"
And I should see the link "everMore"
And I should see the link "EVERmore"
And I should see the link "bat"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bat?

@claudiu-cristea claudiu-cristea merged commit eba444a into develop Jul 13, 2021
@claudiu-cristea claudiu-cristea deleted the ISAICP-6521 branch July 13, 2021 07:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants