Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

ISAICP-6433: Change notification when saving content as draft. #2509

Merged
merged 8 commits into from
Jul 12, 2021

Conversation

saidatom
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jun 28, 2021

CLA assistant check
All committers have signed the CLA.

@saidatom saidatom force-pushed the ISAICP-6433 branch 3 times, most recently from 417e508 to ae599e5 Compare June 28, 2021 21:11
Copy link
Contributor

@claudiu-cristea claudiu-cristea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your first Joinup PR look promising. Good! However, I have few remarks.

Copy link
Contributor

@claudiu-cristea claudiu-cristea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. However, I see the test are failing and I've managed to reproduce the failure locally but didn't investigate. I also have some nitpicks, see my inline comments.

Copy link
Contributor

@claudiu-cristea claudiu-cristea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Looks good, approved

@claudiu-cristea claudiu-cristea merged commit e1bffc8 into develop Jul 12, 2021
@claudiu-cristea claudiu-cristea deleted the ISAICP-6433 branch July 12, 2021 15:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants