This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
ISAICP-6525: Adopt EC Europa QA conventions #2484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is bypassing GrumPHP. As we experienced already in the past the way GrumPHP sets up a dynamic configuration of PHP_CodeSniffer is not compatible with our ruleset. The same problems we saw in the past with the inclusion and exclusion of filename patterns is still persisting. The second tool that GrumPHP is running is PHPMD which has no added value for us and only causes false positives. Both are disabled now, and we have a green pipeline. |
This is a requirement for using the EC continuous integration pipelines.
claudiu-cristea
force-pushed
the
ISAICP-6525
branch
from
cf21c00 to
0e4ab40
Compare
claudiu-cristea
force-pushed
the
ISAICP-6525
branch
from
0e4ab40 to
e488f60
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.