This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
ISAICP-6408: Show unpublished releases in the unpublished section for solutions. #2446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idimopoulos
changed the title
idimopoulos
force-pushed
the
ISAICP-6408
branch
from
44f3a07 to
63cd475
Compare
idimopoulos
force-pushed
the
ISAICP-6408
branch
from
63cd475 to
ff3b12b
Compare
These are supposed to be describing user scenarios for the business to approve, and the fact they can be run as tests is considered to be a happy coincidence.
pfrenssen
suggested changes
Apr 13, 2021
Comment on lines
179
to
181
| # The owner of the content did not create the release as they are simple members. | ||
| And I should not see the following tiles in the "Unpublished content area" region: | ||
| | Hidden spies | |
There was a problem hiding this comment.
This seems like the correct place to test the functionality that is being asked in the ticket: to ensure that the author of an unpublished release can see it. This doesn't seem to not prove what is requested.
Comment on lines
200
to
203
| # Releases are available. | ||
| And I should see the following tiles in the "Unpublished content area" region: | ||
| | The Ragged Streams | | ||
| | Hidden spies | |
There was a problem hiding this comment.
This doesn't seem to be correct, the ticket does not mention that facilitators should be able to see unpublished drafts of releases. It goes against the established pattern "The facilitator should not be able to see content that only have a draft state".
It is requested that authors should see their own releases, not facilitators.
the releases appear in the account page.
… in the user's profile.
idimopoulos
force-pushed
the
ISAICP-6408
branch
from
74572e0 to
6f39b1e
Compare
pfrenssen
approved these changes
Apr 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.