This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
ISAICP-6321: Allow revision access to non moderator users. #2407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of value they have when loaded.
1f627fe
to
69d3abd
Compare
c306dfb
to
e3f90cc
Compare
…gion - revision deletion links.
pfrenssen
suggested changes
Mar 8, 2021
web/modules/custom/joinup_community_content/joinup_community_content.module
Outdated
Show resolved
Hide resolved
web/modules/custom/joinup_community_content/joinup_community_content.module
Outdated
Show resolved
Hide resolved
web/modules/custom/joinup_community_content/src/Access/NodeRevisionAccessCheck.php
Outdated
Show resolved
Hide resolved
…munity content specific features.
…nt publication restrictions in moderated groups.
…s in the meantime been fixed. Ref. Gizra/og@2857814
…roup members according to the new revised scope of the ticket.
…group properties, not community content properties.
By extending FieldableEntityInterface the IDE can make much better sense of the capabilities of entities that implement this interface.
… if a target state is allowed.
…bypass content moderation to a post-moderated workflow. This is preventing code that sends out notifications from determining the actual workflow. We shouldn't pretend that a post-moderated workflow is used if we are in a pre-moderated group.
…n existing content and publish it without facilitator intervention.
… when a new revision is created in proposed state.
…evision is created in proposed state.
…validated to proposed, this is done using the button 'Propose changes', while for a facilitator this remains 'Request changes' as before.
…al member transitions content from validated to proposed.
…e changes to published content.
This came back from UAT with some suggestion to update the scope of this ticket (ref. comments in the Jira ticket). This resulted in some necessary changes to the workflow:
I tried to order the commits for this latest round of changes in a logical way to make it easier to review. The commits are starting on March 19 (commit
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.