This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
Hotfix: Isaicp 4589: Allow facilitators to receive a notification as well on a membership request #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a notification when a user requests a membership and can approve it.
… cannot be requested for solutions.
pfrenssen
reviewed
Jun 20, 2018
| @@ -66,7 +66,7 @@ public function onCreate(NotificationEvent $event) { | |||
| 'rdf_entity-collection-administrator' => [ | |||
| $template_id, | |||
| ], | |||
| 'rdf_entity-solution-administrator' => [ | |||
| 'rdf_entity-collection-facilitator' => [ | |||
There was a problem hiding this comment.
This looks like it is removing the possibility of sending the notifications to solution administrators. I'm not sure if this will affect anything. It is not possible for users to request membership of a solution, but facilitators can add new members at will in order to expand the facilitator team.
The class does not have good documentation explaining what it covers so I am not sure. Let's see what the tests say.
/**
* Class OgMembershipSubscriber.
*/
👍
There was a problem hiding this comment.
Τhere are no membership requests for solutions so the second index is probably wrong and should be rdf_entity-collection-facilitator, thus, making this ticket indeed a bug. There was no spamming question for this issue.
pfrenssen
approved these changes
Jun 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.