Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure address is defined before checking against an excluded hostname prefix #2

Merged
merged 1 commit into from
May 7, 2024
Merged

Ensure address is defined before checking against an excluded hostname prefix #2

merged 1 commit into from
May 7, 2024

Conversation

jonhaddow
Copy link

DNS failed for the corsproxy instance and resulted in runtime error from the dnsLookup function.

This change adds a protection against an undefined address value, which kills the instance.

Makeshift
Makeshift approved these changes May 7, 2024
View reviewed changes
Copy link

@Makeshift Makeshift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jon!

@jonhaddow jonhaddow merged commit 0a53e43 into master May 7, 2024
@jonhaddow jonhaddow deleted the SL-9993 branch May 7, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Makeshift Makeshift Makeshift approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonhaddow @Makeshift