Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance when creating Reaper automation points #252

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

firthm01
Copy link
Contributor

@firthm01 firthm01 commented Sep 14, 2023

Rebased version of #250 to run CI (main had CI disk space fix)

Original PR description from @carmethene :

See: https://www.reaper.fm/sdk/reascript/reascripthelp.html#InsertEnvelopePoint InsertEnvelopePoint()'s sort control flag works opposite to the way you'd expect. Flipping this code around prevents Reaper from re-sorting the automation curve for each point added, which significantly reduces execution time.

See: https://www.reaper.fm/sdk/reascript/reascripthelp.html#InsertEnvelopePoint
InsertEnvelopePoint()'s sort control flag works opposite to the way you'd expect.  Flipping this code around prevents Reaper from re-sorting the automation curve for each point added, which significantly reduces execution time.
@firthm01 firthm01 marked this pull request as ready for review September 14, 2023 15:30
@firthm01 firthm01 merged commit 9a5c788 into main Sep 14, 2023
@firthm01 firthm01 deleted the envelope-import-rebased branch September 14, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants