Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip package missing wetb and tools sub folders #27

Closed
mutricyl opened this issue Jan 30, 2024 · 2 comments
Closed

pip package missing wetb and tools sub folders #27

mutricyl opened this issue Jan 30, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@mutricyl
Copy link

Hello

When using weio with pip package (pip install weio) some folders are missing that prevent weio to read files:

weio.read('data/HAN016_V105_Wd000_Wv000_H063_T105_C180_S01.out')
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "C:\Users\laurent.mutricy\AppData\Local\miniconda3\envs\py310\lib\site-packages\weio\__init__.py", line 246, in read
    fileformat,F = detectFormat(filename, **kwargs)
  File "C:\Users\laurent.mutricy\AppData\Local\miniconda3\envs\py310\lib\site-packages\weio\__init__.py", line 212, in detectFormat
    formats=fileFormats()
  File "C:\Users\laurent.mutricy\AppData\Local\miniconda3\envs\py310\lib\site-packages\weio\__init__.py", line 32, in fileFormats
    from .hawc2_pc_file           import HAWC2PCFile
  File "C:\Users\laurent.mutricy\AppData\Local\miniconda3\envs\py310\lib\site-packages\weio\hawc2_pc_file.py", line 15, in <module>
    from .wetb.hawc2.pc_file import PCFile
ModuleNotFoundError: No module named 'weio.wetb'

May I suggest to modify setup.py line 39 from packages=find_packages(include=['weio'],exclude=['./__init__.py']), to packages=find_packages(include=['weio', 'weio/wetb', 'weio/tools'],exclude=['./__init__.py']), to solve the issue ?

@mutricyl
Copy link
Author

looks like a duplicate of #22

Sorry I have suggested an improper modification.
find_packages(include=['weio', 'weio.wetb*', 'weio.tools'],exclude=['./__init__.py']) should perform better.

mutricyl pushed a commit to mutricyl/weio that referenced this issue Feb 15, 2024
@ebranlard ebranlard added the bug Something isn't working label Feb 17, 2024
@ebranlard
Copy link
Owner

Thank you for your help!

ebranlard pushed a commit that referenced this issue Mar 1, 2024
…#29)

* fast output file description in read and write, resolves #28

* small correction

* resolves #27

* write ascii return close to initial file

* remove panda.series deprecation warning

* more robust write function

---------

Co-authored-by: Laurent Mutricy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants