Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #148 - log4j stderr message about not finding a logging implementation when using jsign CLI #206

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Fixes #148 - log4j stderr message about not finding a logging implementation when using jsign CLI #206

merged 1 commit into from
Mar 1, 2024

Conversation

davoustp
Copy link
Contributor

@davoustp davoustp commented Mar 1, 2024 •
edited
Loading

This fix makes the suggestion from #148 (comment) permanent, by leveraging the log4j2 properties mechanism (instead of relying onto users to do it themselves, struggling with passing Java props to an executable jar).

Reference:

@ebourg
Copy link
Owner

ebourg commented Mar 1, 2024

Merci ! I guess the log4j2.loggerContextFactory property can be removed from jsign.sh and jsign.cmd too.

@davoustp
Copy link
Contributor Author

davoustp commented Mar 1, 2024 •
edited
Loading

Merci ! I guess the log4j2.loggerContextFactory property can be removed from jsign.sh and jsign.cmd too.

De rien! ;-)
I did commit this small change as well (these files went under the radar).

@ebourg ebourg merged commit dd4f9f0 into ebourg:master Mar 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davoustp @ebourg