purego: use syscall.syscallX for functions with 3 or less arguments #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hajimehoshi
reviewed
May 24, 2022
syscall.go
Outdated
| @@ -21,6 +21,11 @@ func SyscallN(fn uintptr, args ...uintptr) (r1, r2, err uintptr) { | |||
| if len(args) > maxArgs { | |||
| panic("too many arguments to SyscallN") | |||
| } | |||
| if len(args) <= 3 { | |||
There was a problem hiding this comment.
- Could you write a comment why we needed this?
- Do functions with 4-6 arguments work as expected?
There was a problem hiding this comment.
I believe so but just in case I used the 6 version instead of the 3 version. The tests still seem to pass.
|
Also I'd be happy if you could take a look at these comments: |
this commit also fixes some issues with comments
TotallyGamerJet
added a commit
to TotallyGamerJet/purego
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.