all: struct return fixes #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On amd64, objective-c crashed when calling objc.Send with a struct return type. This was due to calling the wrong objc message send function. On arm64, if a struct return contained structs that only contained floats it would expect it to be in R8 instead of the expected float registers There are tests for all of the above.
hajimehoshi
approved these changes
Apr 4, 2024
|
@hajimehoshi if this does fix the issue in ebitengine should this be cherry-picked for 0.7? |
|
Confirmed this worked perfectly with Ebitengine. I'll update go.mod. |
hajimehoshi
pushed a commit
that referenced
this pull request
Apr 4, 2024
On amd64, there was a crash when calling objc.Send with a struct return type. This was due to calling the wrong objc message send function. On arm64, if a struct return contained structs that only contained floats it would expect it to be in R8 instead of the expected float registers Closes #223
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On amd64, there was a crash when calling objc.Send with a struct return type. This was due to calling the wrong objc message send function.
On arm64, if a struct return contained structs that only contained floats it would expect it to be in R8 instead of the expected float registers
Closes #223