FIX: DB2 migration: call reorg after drop not null #2822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @rbygrave ,
we found a bug in the generation of the db2 migration scripts: after dropping the
@Nonnullannotation the table should be reorganized. The fix is inDB2Ddl.checkReorg().I created test Data in ETable which has a reserved keyword
tableas table name. That caused some other problems in the stored procedures. I fixed it too for sqlserver, mariadb & mysql.I will push the migration scipts in a separate commit that we can revert if develop branch changes.
Kind regards,
Noemi