Bug: fetch and where with formula join will produce incorrect joins #2773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWagner
changed the title
AlexWagner
changed the title
|
@rbygrave any ideas on this? |
|
Sorry, I've been focused on the enhancement stuff. Looking to get a release out and then I hope to get some time to look at this. |
rPraml
added a commit
to FOCONIS/ebean
that referenced
this pull request
Jan 12, 2023
rPraml
added a commit
to FOCONIS/ebean
that referenced
this pull request
Jan 12, 2023
|
I feel that we really need a logical version of |
rPraml
added a commit
to FOCONIS/ebean
that referenced
this pull request
Aug 10, 2023
…ce incorrect joins
rPraml
force-pushed
the
bug-fetch-and-where-formula-join
branch
from
c8e325c to
932c8a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a fetch and where on a formula joined field (maybe others are also affected) in a query,
the joins are build incorrectly.
The table alias is wrong, if you have a where clause with 3 path components and a fetch with 2.
See test case with childPerson -> parentPerson -> effectiveBean
The problem is somewhere located here:
https://github.com/ebean-orm/ebean/blob/master/ebean-core/src/main/java/io/ebeaninternal/server/query/SqlTreeBuilder.java#L680
"where" generates an extra join which is effectivly added to the root bean und not to the already existing child (from the select/fetch)