Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Illegal value for Track reported in Homebridge v1.3.0 #165

Closed
jsiegenthaler opened this issue Feb 20, 2021 · 4 comments
Closed

Illegal value for Track reported in Homebridge v1.3.0 #165

jsiegenthaler opened this issue Feb 20, 2021 · 4 comments
Labels

Comments

@jsiegenthaler
Copy link

Issue

Illegal value for Track reported in Homebridge v1.3.0
Using homebridge-zp v1.1.6
You could consider truncating the characteristic value.

Log Messages

[20/02/2021, 10:39:59] [homebridge-zp] This plugin generated a warning from the characteristic 'Track': characteristic was supplied illegal value: string 'Radio SRF 3 - srf3.ch - [email protected] - facebook/srf3 - twitter @srf3 - instagram/srf3' exceeded max length of 64. See https://git.io/JtMGR for more info.

Debug Files

@jsiegenthaler
Copy link
Author

Hello @ebaauw

I logged the warning with Debug mode on:

[24/02/2021, 06:46:52] [homebridge-zp] This plugin generated a warning from the characteristic 'Track': characteristic was supplied illegal value: string 'Radio SRF 3 - srf3.ch - [email protected] - facebook/srf3 - twitter @srf3 - instagram/srf3' exceeded max length of 64. See https://git.io/JtMGR for more info.
[24/02/2021, 06:46:52] [homebridge-zp] Error: 
    at Characteristic.characteristicWarning (/usr/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Characteristic.ts:2164:105)
    at Characteristic.validateUserInput (/usr/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Characteristic.ts:2088:16)
    at Characteristic.updateValue (/usr/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Characteristic.ts:1365:20)
    at CharacteristicDelegate.set value [as value] (/usr/lib/node_modules/homebridge-zp/node_modules/homebridge-lib/lib/CharacteristicDelegate.js:275:28)
    at Object.set (/usr/lib/node_modules/homebridge-zp/node_modules/homebridge-lib/lib/ServiceDelegate.js:258:50)
    at Sonos.handleMediaRendererAVTransportEvent (/usr/lib/node_modules/homebridge-zp/lib/ZpService.js:479:32)
    at ZpClient.<anonymous> (/usr/lib/node_modules/homebridge-zp/lib/ZpService.js:41:18)
    at ZpClient.emit (events.js:327:22)
    at IncomingMessage.<anonymous> (/usr/lib/node_modules/homebridge-zp/lib/ZpListener.js:100:22)
    at runMicrotasks (<anonymous>)

@ebaauw ebaauw added the bug label Feb 24, 2021
@ebaauw
Copy link
Owner

ebaauw commented Feb 24, 2021

Thanks for the report. I'll have a look at this for the next version. Not sure yet whether to increase the length of Track or to slice the reported value. I don't think you'll be able to see the entire string in a HomeKit app?

@jsiegenthaler
Copy link
Author

Hi. I think truncating the string would be the simplest. I don't know of any HomeKit app that could display 64 characters anyway...

ebaauw added a commit that referenced this issue Feb 25, 2021
Limit _Track_ to 64 characters, see #165.
@ebaauw
Copy link
Owner

ebaauw commented Feb 25, 2021

In v.1.1.7.

@ebaauw ebaauw closed this as completed Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants