Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update docusaurus to 2.0.0-rc.1 #226

Merged
merged 4 commits into from
Jul 19, 2022

Conversation

utybo
Copy link
Contributor

@utybo utybo commented Jul 18, 2022

I believe there are other issues related 2.0.0-rc.1, but at least it compiles with this PR! 🚀

Edit: I've added a fix for a problem I encountered while trying to use the new version with a website that does not use versions. The fix is a complete hack but I'm not aware of any way of making this better. Feel free to edit my PR if you have a better solution for this.

@netlify
Copy link

netlify bot commented Jul 18, 2022

Deploy Preview for easyops-cn-docusaurus-search-local ready!

Name Link
🔨 Latest commit 3b8acca
🔍 Latest deploy log https://app.netlify.com/sites/easyops-cn-docusaurus-search-local/deploys/62d60568ceb50a0008ef7299
😎 Deploy Preview https://deploy-preview-226--easyops-cn-docusaurus-search-local.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@utybo
Copy link
Contributor Author

utybo commented Jul 18, 2022

There are still issues when not using versions, I'll probably use the same hack everywhere applicable. I've added it to SearchPage.

@utybo
Copy link
Contributor Author

utybo commented Jul 18, 2022

In case people are interested, I have published my fixes as @utybo/docusaurus-search-local on NPM. I'm currently using it to check that nothing else is broken on several of our (non-public) Docusaurus sites.

docusaurus-search-local/package.json Outdated Show resolved Hide resolved
// moduleResolution and module are required because Docusaurus uses 'exports' in its package.json
// See here for more information: https://github.com/microsoft/TypeScript/issues/33079#issuecomment-1169377037
"moduleResolution": "Node16",
"module": "Node16",
Copy link
Member

@weareoutman weareoutman Jul 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks, I tried to upgrade docusaurus to rc.1, but failed, I believe this is the magic here :)

@weareoutman weareoutman enabled auto-merge July 19, 2022 01:18
@weareoutman weareoutman merged commit 25c3f38 into easyops-cn:master Jul 19, 2022
@weareoutman
Copy link
Member

weareoutman commented Jul 19, 2022

Thanks! Released v0.29.1

@utybo
Copy link
Contributor Author

utybo commented Jul 19, 2022

Thank you very much for the fast merge and release! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants