-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename unclear *run*
methods to *install_extension*
+ rename install_extensions
to install_all_extensions
#4400
Conversation
@boegel I made your suggested changes |
run
methods to install extensions
@lexming We need a companion PR in easyblocks too? |
run
methods to install extensions*run*
methods to *install_extension*
+ rename install_extensions
to install_all_extensions
…ct and use any custom deprecated methods in the Easyblock
This comment was marked as outdated.
This comment was marked as outdated.
@boegel all tests positive, this is ready |
enhance install_extension_substep to support passing down (named) arguments
…on.install_extension_substep
This comment was marked as outdated.
This comment was marked as outdated.
…tall_extension_substep
This comment was marked as outdated.
This comment was marked as outdated.
@boegel added unit tests for the new method If you think that adding those extra easyblocks is overkill, we can also just test the case where an easyblock directly defines custom or deprecated Regarding the use of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
fixes #4113
run()
->install_extension()
prerun()
->pre_install_extension()
postrun()
->post_install_extension()
run_async()
->install_extension_async()
install_extensions()
->install_all_extensions()