Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{chem} [intel/2021b] WIEN2k 23.2 update #19247

Merged

Conversation

lcniel
Copy link
Contributor

@lcniel lcniel commented Nov 16, 2023

(created using eb --new-pr)

Include easybuild-easyblocks/pull/3035

@lcniel lcniel changed the title Build for new WIEN2k versions, include easybuild-easyblocks/pull/3035 {chem} [intel/2021b] WIEN2k 23.2 update Nov 16, 2023
@lcniel
Copy link
Contributor Author

lcniel commented Nov 16, 2023

Test report by @lcniel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3035
FAILED
Failed during parsing of the easyconfigs, so no ecs were built (1 easyconfigs in total)
vera-gpu2 - Linux Rocky Linux 8.8, x86_64, Intel(R) Xeon(R) Gold 6130 CPU @ 2.10GHz, 1 x NVIDIA Tesla V100-SXM2-32GB, 535.104.05, Python 3.6.8
See https://gist.github.com/lcniel/d4a7727bebb0ec9e7e4f763f82d0067c for a full test report.

@lcniel
Copy link
Contributor Author

lcniel commented Nov 16, 2023

Test report by @lcniel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3035
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
vera37-2 - Linux Rocky Linux 8.8, x86_64, Intel(R) Xeon(R) Gold 6130 CPU @ 2.10GHz, Python 3.6.8
See https://gist.github.com/lcniel/1032d2cc02c2255a026e694cbf3aafa7 for a full test report.

@lcniel
Copy link
Contributor Author

lcniel commented Nov 16, 2023

Test report by @lcniel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3035
FAILED
Build succeeded for 1 out of 2 (1 easyconfigs in total)
vera37-2 - Linux Rocky Linux 8.8, x86_64, Intel(R) Xeon(R) Gold 6130 CPU @ 2.10GHz, Python 3.6.8
See https://gist.github.com/lcniel/cf188f35d3dc576417a25cda2c280590 for a full test report.

@lcniel
Copy link
Contributor Author

lcniel commented Nov 16, 2023

Test report by @lcniel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3035
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
vera37-2 - Linux Rocky Linux 8.8, x86_64, Intel(R) Xeon(R) Gold 6130 CPU @ 2.10GHz, Python 3.6.8
See https://gist.github.com/lcniel/35f57e4441d6335f010d0d5229862d17 for a full test report.

@lcniel
Copy link
Contributor Author

lcniel commented Nov 16, 2023

Test report by @lcniel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3035
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
vera37-2 - Linux Rocky Linux 8.8, x86_64, Intel(R) Xeon(R) Gold 6130 CPU @ 2.10GHz, Python 3.6.8
See https://gist.github.com/lcniel/5632cfd137f0bd969eea992e63a95866 for a full test report.

@lcniel
Copy link
Contributor Author

lcniel commented Nov 16, 2023

Test report by @lcniel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3035
SUCCESS
Build succeeded for 0 out of 0 (1 easyconfigs in total)
vera37-2 - Linux Rocky Linux 8.8, x86_64, Intel(R) Xeon(R) Gold 6130 CPU @ 2.10GHz, Python 3.6.8
See https://gist.github.com/lcniel/e014e056d1a91d810f225b6a90d0e343 for a full test report.

@lcniel
Copy link
Contributor Author

lcniel commented Nov 16, 2023

Test report by @lcniel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3035
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
vera37-2 - Linux Rocky Linux 8.8, x86_64, Intel(R) Xeon(R) Gold 6130 CPU @ 2.10GHz, Python 3.6.8
See https://gist.github.com/lcniel/120547b095165bf13cb3b70e45377cb8 for a full test report.

@lcniel
Copy link
Contributor Author

lcniel commented Nov 16, 2023

Test report by @lcniel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3035
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
vera37-2 - Linux Rocky Linux 8.8, x86_64, Intel(R) Xeon(R) Gold 6130 CPU @ 2.10GHz, Python 3.6.8
See https://gist.github.com/lcniel/a6adbcf7ca3ace06ca29e0111a2a4661 for a full test report.

@boegelbot
Copy link
Collaborator

@lcniel: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/6894404499
Output from first failing test suite run:

FAIL: test_pr_patch_descr (test.easyconfigs.easyconfigs.EasyConfigTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 1293, in test_pr_patch_descr
    self.assertFalse(no_descr_patches, "No description found in patches: %s" % ', '.join(no_descr_patches))
AssertionError: ['/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/w/WIEN2k/WIEN2k-23.2_fix_system_stderr_redirection.patch'] is not false : No description found in patches: /home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/w/WIEN2k/WIEN2k-23.2_fix_system_stderr_redirection.patch

======================================================================
FAIL: test_pr_sha256_checksums (test.easyconfigs.easyconfigs.EasyConfigTest)
Make sure changed easyconfigs have SHA256 checksums in place.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 999, in test_pr_sha256_checksums
    self.assertTrue(len(checksum_issues) == 0, "No checksum issues:\n%s" % '\n'.join(checksum_issues))
AssertionError: False is not true : No checksum issues:
Checksums missing for one or more sources/patches in WIEN2k-23.2-intel-2021b.eb: found 1 sources + 2 patches vs 0 checksums

----------------------------------------------------------------------
Ran 18537 tests in 694.573s

FAILED (failures=2)
ERROR: Not all tests were successful

bleep, bloop, I'm just a bot (boegelbot v20200716.01)
Please talk to my owner @boegel if you notice me acting stupid),
or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

@easybuilders easybuilders deleted a comment from boegelbot Nov 22, 2023
@easybuilders easybuilders deleted a comment from boegelbot Nov 22, 2023
@easybuilders easybuilders deleted a comment from boegelbot Nov 22, 2023
@boegel boegel added the update label Nov 22, 2023
@boegel boegel added this to the 4.x milestone Nov 22, 2023
@easybuilders easybuilders deleted a comment from boegelbot Nov 22, 2023
@easybuilders easybuilders deleted a comment from boegelbot Nov 22, 2023
@boegel
Copy link
Member

boegel commented Nov 22, 2023

@lcniel Can you add the missing patch description + checksums?

@lcniel
Copy link
Contributor Author

lcniel commented Nov 25, 2023

@lcniel Can you add the missing patch description + checksums?

Yes, I will take care of it on Monday, I just haven't had time this week.

@lcniel
Copy link
Contributor Author

lcniel commented Nov 27, 2023

@boegel All tests now pass.

@akesandgren
Copy link
Contributor

Test report by @akesandgren
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3035
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
b-an02.hpc2n.umu.se - Linux Ubuntu 20.04, x86_64, Intel(R) Xeon(R) CPU E5-2690 v4 @ 2.60GHz, Python 3.8.10
See https://gist.github.com/akesandgren/115c38e8ac386252470493117dc2b3a1 for a full test report.


osdependencies = [
('glibc-devel', 'libc6-dev'), # required for libpthread.
('tcsh', '6.24.01')
Copy link
Contributor

@akesandgren akesandgren Jan 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not how osdeps works, the tuple is supposed to be various names of the package from different OS:es like the one above which is RHEL vs DEB names.
So drop the 6.24.01 part.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren akesandgren modified the milestones: 4.x, release after 4.9.0 Jan 9, 2024
@akesandgren
Copy link
Contributor

Going in, thanks @lcniel!

@akesandgren akesandgren merged commit 6057663 into easybuilders:develop Jan 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants