Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CMake print summary for long hostnames for NECI #17230

Merged

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Jan 28, 2023

(created using eb --new-pr)

FIx the issue seen in #16862 (comment) which happens if the hostname is too long. The patch takes out the nice alignment in the printing of the summary, but does not fail on long hostnames.

CMake Error at cmake/neci_print_summary.cmake:32 (string):
  string begin index: 53 is out of range 0 - 51
Call Stack (most recent call first):
  cmake/neci_print_summary.cmake:45 (box_side)
  CMakeLists.txt:156 (neci_print_summary)


-- Configuring incomplete, errors occurred!

@branfosj branfosj added this to the next release (4.7.1?) milestone Jan 28, 2023
@branfosj
Copy link
Member Author

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@branfosj: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=17230 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_17230 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 2133

Test results coming soon (I hope)...

- notification for comment with ID 1407387885 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/dec5c19a6e3a90d9e6ed53836cb193ed for a full test report.

@branfosj
Copy link
Member Author

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0105u36b.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/71820b599a4ea3ec89fadbafb2680d15 for a full test report.

@boegel
Copy link
Member

boegel commented Jan 29, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=17230 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17230 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10085

Test results coming soon (I hope)...

- notification for comment with ID 1407601921 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Member

boegel commented Jan 29, 2023

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3147.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/25431d265b10ec749b14cbc807c6e09b for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/53827dcd8a7f3a1f252d77db4a41bb5f for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Jan 29, 2023

Going in, thanks @branfosj!

@boegel boegel merged commit cb95a4e into easybuilders:develop Jan 29, 2023
@boegel
Copy link
Member

boegel commented Jan 29, 2023

@branfosj Thanks a lot for the fix!

Maybe it's worth pushing this upstream (or at least reporting the issue upstream)?

@branfosj branfosj deleted the 20230128121834_new_pr_NECI20220711 branch January 29, 2023 11:20
@branfosj
Copy link
Member Author

@branfosj Thanks a lot for the fix!

Maybe it's worth pushing this upstream (or at least reporting the issue upstream)?

I've reported it to them: ghb24/NECI_STABLE#11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants