-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix CMake print summary for long hostnames for NECI #17230
fix CMake print summary for long hostnames for NECI #17230
Conversation
@boegelbot please test @ jsc-zen2 |
@branfosj: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1407387885 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Test report by @branfosj |
@boegelbot please test @ generoso |
@boegel: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1407601921 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegel |
Test report by @boegelbot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Going in, thanks @branfosj! |
@branfosj Thanks a lot for the fix! Maybe it's worth pushing this upstream (or at least reporting the issue upstream)? |
I've reported it to them: ghb24/NECI_STABLE#11 |
(created using
eb --new-pr
)FIx the issue seen in #16862 (comment) which happens if the hostname is too long. The patch takes out the nice alignment in the printing of the summary, but does not fail on long hostnames.