Update Error Classification mechanism #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuanCrg90
commented
Jan 28, 2021
| end | ||
|
|
||
| def test_invalid_token_error | ||
| assert_token_error('error' => 'invalid_token') | ||
| body = { "message": "invalid_token", "error": "not_found", "status": 401, "cause":[] } |
There was a problem hiding this comment.
I took the error responses from recorded vcr files, I don't have a vcr for the forbidden error, but we can update it in case the error message is different.
Mercado Libre doesn't have a uniform error structure. For example the
invalid_token error has in the error key "not_found"
{ "message": "invalid_token", "error": "not_found", "status": 401, "cause":[] }
Or malformed access_token comes as a bad_request error
{ "message": "Malformed access_token: test","error": "bad_request", "status": 400, "cause":[] }
This updates the error classification mechanism to use the description
as the first alternative to classify the error.
JuanCrg90
force-pushed
the
improve_error_classification
branch
from
544161f to
aa2077e
Compare
JuanCrg90
commented
Jan 28, 2021
| status_error = STATUS_ERRORS[response.code] | ||
| raise status_error.new(response) if status_error | ||
| def error_message_from_body(response) | ||
| return if response.body.nil? |
There was a problem hiding this comment.
[DEPRECATION] HTTParty will no longer override
response#nil?. This functionality will be removed in future versions. Please, add explicit checkresponse.body.nil? || response.body.empty?. For more info refer to: jnunemaker/httparty#568
enortham
reviewed
Jan 28, 2021
JuanCrg90
force-pushed
the
improve_error_classification
branch
from
aa2077e to
617690c
Compare
|
@enortham friendly reminder |
enortham
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mercado Libre doesn't have a uniform error structure. For example the
invalid_token error has in the error key "not_found"
Or malformed access_token comes as a bad_request error
This updates the error classification mechanism to use the description
as the first alternative to classify the error.