Update easol-canvas to v3.1 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianmooney
force-pushed
the
ian/update-canvas-version
branch
2 times, most recently
from
8dff8d4 to
7ad4b9f
Compare
The latest version of canvas is v3.1.0, which allows the currency_switcher tag when validating Liquid. Since #3, we are now specifying the exact version of the `easol-canvas` gem. This means there will be some extra steps when there is a an update the the canvas gem. Each time there is an update, we'll need to do the following: 1. Bump the `easol-canvas` gem version. 2. Update `easolhq/canvas-linter-action` to use the new gem version. 3. Update the theme's `.github/workflows/lint.yml` to use the new version of canvas-linter-action. This might be cumbersome and also means that existing themes that don't update their canvas-linter-action version won't benefit from the latest validation checks. This commit proposes we make the gem version more generic and only require this linter action to to be updated when there major version changes on the gem.
ianmooney
force-pushed
the
ian/update-canvas-version
branch
from
7ad4b9f to
8a07702
Compare
|
@ianmooney not 3.1? |
tomchipchase
approved these changes
Nov 25, 2022
|
Because of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of canvas is v3.1.0, which allows the
currency_switcher tag when validating Liquid.
Since #3, we are
now specifying the exact version of the
easol-canvasgem.This means there will be some extra steps when there is a an update
the the canvas gem. Each time there is an update, we'll need to do
the following:
easol-canvasgem version.easolhq/canvas-linter-actionto use the new gem version..github/workflows/lint.ymlto use the newversion of canvas-linter-action.
This might be cumbersome and also means that existing themes that don't
update their canvas-linter-action version won't benefit from the latest
validation checks.
This commit proposes we make the gem version more generic and only
require this linter action to to be updated when there major version
changes on the gem.