Use ruby slim image instead of alpine #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dockerfile
Outdated
| @@ -1,4 +1,4 @@ | |||
| FROM ruby:3.2.1-alpine | |||
| FROM ruby:3.1.4 | |||
There was a problem hiding this comment.
The fact that this works suggests there's a package we could install into the slim version to get it to work.
Is adding
RUN apt install -y build-essential enough to get this to work with the slim image?
There was a problem hiding this comment.
Unfortunately I get the following error - E: Unable to locate package build-essential
https://github.com/easolhq/alchemist-theme/actions/runs/6863696394/job/18671649930
There was a problem hiding this comment.
Ah it works with the following:
RUN apt update
RUN apt install -y build-essential
There was a problem hiding this comment.
You'll want to do that on one line and clear the package data to keep the image size down, otherwise it caches the intermediate layers, and we end up with a larger image:
RUN apt update && apt install -y build-essential && rm -rf /var/lib/apt/lists/*
ianmooney
force-pushed
the
slug-361-canvas-linter-action-broken
branch
2 times, most recently
from
f376275 to
ee1c503
Compare
tomchipchase
approved these changes
Nov 14, 2023
We are seeing the following error when this Github action is executed: ERROR: glibc-2.34-r0: trying to overwrite etc/nsswitch.conf owned by alpine-baselayout-data-3.2.0-r23. There seems to be a problem when it attempts to install glibc, which is needed as a native dependency for dartsass. This commit resolves this by using a slim image instead of alpine, which already includes the `glibc` package, so it doesn't need to be explicitly installed. We need to install the `build-essential` package so that native gem dependencies are installed successfully. Otherwise we recieve the following error when installing native dependencies for the racc gem, which is a dependency of nokogiri: current directory: /usr/local/bundle/gems/racc-1.7.3/ext/racc/cparse make DESTDIR\= sitearchdir\=./.gem.20231114-7-jo9434 sitelibdir\=./.gem.20231114-7-jo9434 clean current directory: /usr/local/bundle/gems/racc-1.7.3/ext/racc/cparse make DESTDIR\= sitearchdir\=./.gem.20231114-7-jo9434 sitelibdir\=./.gem.20231114-7-jo9434 make failedNo such file or directory - make The `rm -rf /var/lib/apt/lists/*` part will clear the package data and help keep the overall image size small. We are targeting ruby v3.1.4, as this matches the version we currently use in the easol Rails app.
ianmooney
force-pushed
the
slug-361-canvas-linter-action-broken
branch
from
ee1c503 to
2e7c468
Compare
ianmooney
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing the following error when this Github action is executed:
There seems to be a problem when it attempts to install glibc, which is needed as a native dependency for dartsass.
We are also seeing this error when installing native dependencies for the racc gem, which is a dependency of nokogiri:
This commit solves both these errors by using the base image for ruby, instead of the alpine image. The base image is about 10x larger but solves the problem and doesn't seem to slow down the build too much.
Targeting ruby v3.1.4, as this matches the version we currently use in the easol Rails app.