Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "now playing" update and add graceful closure #2

Merged
merged 2 commits into from
Mar 14, 2019
Merged

Fix "now playing" update and add graceful closure #2

merged 2 commits into from
Mar 14, 2019

Conversation

andrewsayre
Copy link
Contributor

This PR fixes a few issues:

  • Removes player_id from the controller class and corrected methods that were still using the hard-coded player_id from device 0. This resolves the issue where the now playing media was not updating on devices other than the first one.
  • Standardized usage of host and post so that it is used consistently throughout and removed host and post from connect as this was redundant to the parameters passed into init.
  • Close is now a coroutine and contains logic to ensure a graceful shutdown.
  • Added missing package pytz to requirements and setup.py

@andrewsayre andrewsayre changed the title Fix now playing update and add graceful closure Fix "now playing" update and add graceful closure Mar 14, 2019
@easink
Copy link
Owner

easink commented Mar 14, 2019

Nice work

@easink easink merged commit f054f4a into easink:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants