-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Health check #1143
Health check #1143
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1143 +/- ##
==========================================
- Coverage 81.25% 81.18% -0.07%
==========================================
Files 148 149 +1
Lines 16620 16941 +321
==========================================
+ Hits 13505 13754 +249
- Misses 2474 2530 +56
- Partials 641 657 +16 ☔ View full report in Codecov by Sentry. |
interval: 60s | ||
|
||
# uri for health check http request | ||
uri: /health |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think path
would be more precise here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uri
contains path
, and query
part of url
, which is more general. uri
here means user can also put query part in yaml here.
This follows the design of nginx health check and caddy health check.
# response validation criteria (default: 2xx and 3xx status codes) | ||
match: | ||
# acceptable status code ranges | ||
statusCode: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
statusCodes
would be more correct grammatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated!
docs/02.Tutorials/2.6.Websocket.md
Outdated
# response validation criteria (default: 101 Switching Protocols) | ||
match: | ||
# acceptable status code ranges | ||
statusCode: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
No description provided.