net/url: fix JoinPath

Fixes golang#52074
earthboundkid · Apr 5, 2022 · 6342cca · 6342cca
1 parent 9e16cc1
commit 6342cca
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/net/url/url.go b/src/net/url/url.go
@@ -1193,7 +1193,11 @@ func (u *URL) JoinPath(elem ...string) *URL {
 	url := *u
 	if len(elem) > 0 {
 		elem = append([]string{u.Path}, elem...)
-		url.setPath(path.Join(elem...))
+		p := path.Join(elem...)
+		if strings.HasSuffix(elem[len(elem)-1], "/") {
+			p += "/"
+		}
+		url.setPath(p)
 	}
 	return &url
 }

diff --git a/src/net/url/url_test.go b/src/net/url/url_test.go
@@ -2095,6 +2095,16 @@ func TestJoinPath(t *testing.T) {
 			elem: []string{"/go", "a", "b", "c"},
 			out:  "https://go.googlesource.com/go/a/b/c",
 		},
+		{
+			base: "https://go.googlesource.com/go/a/",
+			elem: []string{},
+			out:  "https://go.googlesource.com/go/a/",
+		},
+		{
+			base: "https://go.googlesource.com/go/a/",
+			elem: []string{"b/"},
+			out:  "https://go.googlesource.com/go/a/b/",
+		},
 		{
 			base: "http://[fe80::1%en0]:8080/",
 			elem: []string{"/go"},