Prevent unhandled promise rejections for hidden frames

niklasvh#1502
earshinov · Feb 24, 2019 · 07091e1 · 07091e1
1 parent 41eb8ab
commit 07091e1
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/Clone.js b/src/Clone.js
@@ -213,7 +213,12 @@ export class DocumentCloner {
                         new Promise((resolve, reject) => {
                             const iframeCanvas = document.createElement('img');
                             iframeCanvas.onload = () => resolve(canvas);
-                            iframeCanvas.onerror = reject;
+                            iframeCanvas.onerror = function(event) {
+                                // Empty iframes may result in empty "data:," URLs, which are invalid from the <img>'s point of view
+                                // and instead of `onload` cause `onerror` and unhandled rejection warnings
+                                // https://github.com/niklasvh/html2canvas/issues/1502
+                                iframeCanvas.src == 'data:,' ? resolve(canvas) : reject(event);
+                            };
                             iframeCanvas.src = canvas.toDataURL();
                             if (tempIframe.parentNode) {
                                 tempIframe.parentNode.replaceChild(