Removed check on kickofftimearg (flyteorg#388)

Signed-off-by: Prafulla Mahindrakar <[email protected]>
eapolinario · Apr 5, 2022 · 860ebfb · 860ebfb
1 parent f36e48c
commit 860ebfb
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/flyteadmin/pkg/manager/impl/launch_plan_manager.go b/flyteadmin/pkg/manager/impl/launch_plan_manager.go
@@ -145,9 +145,6 @@ func isScheduleEmpty(launchPlanSpec admin.LaunchPlanSpec) bool {
 	if schedule.GetCronSchedule() != nil && len(schedule.GetCronSchedule().Schedule) != 0 {
 		return false
 	}
-	if len(schedule.GetKickoffTimeInputArg()) != 0 {
-		return false
-	}
 	if len(schedule.GetCronExpression()) != 0 {
 		return false
 	}

diff --git a/flyteadmin/pkg/manager/impl/launch_plan_manager_test.go b/flyteadmin/pkg/manager/impl/launch_plan_manager_test.go
@@ -1407,6 +1407,6 @@ func TestIsScheduleEmpty(t *testing.T) {
 				},
 			},
 		}
-		assert.False(t, isScheduleEmpty(sp))
+		assert.True(t, isScheduleEmpty(sp))
 	})
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -1407,6 +1407,6 @@ func TestIsScheduleEmpty(t *testing.T) { @@
     				},
     			},
     		}
-    		assert.False(t, isScheduleEmpty(sp))
+    		assert.True(t, isScheduleEmpty(sp))
     	})
     }