chore: upgrade to sb7 for support node 20 #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ealush
reviewed
Nov 8, 2023
|
@shootermv, ok there's some progress. Thanks for following up on your PR. We passed the install/build stage - but now I am seeing another issue when trying to run storybook. I am assuming there's a bit more tweakign to do, but not much. LMK if you need me to step in and take a look as well.
|
|
Totally.
As far as i can see - it is something with typescript transpilation
Someone recommended me to move to vite from tsdx.
He pointed out that tsdx is not maintened anymore
Is it something that can taake place (in your opinion)?
…On Sun, Nov 12, 2023, 16:50 Evyatar ***@***.***> wrote:
@shootermv <https://github.com/shootermv>, ok there's some progress. We
passed the install/build stage - but now I am seeing another issue when
trying to run storybook.
[image: image]
<https://user-images.githubusercontent.com/11255103/282306377-1357033d-1afe-4e78-8dd4-6c9a5faf6092.png>
—
Reply to this email directly, view it on GitHub
<#373 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKGMHQXRZBROTFJ3QMT2TLYEDOZ5AVCNFSM6AAAAAA7CN3VH2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBXGE2DSNJTGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@shootermv yes, if you have the time and the will to migrate to vite, I will very much appreciate this effort |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what im trying to do here:
For make the storybook run on node 20 - im upgrading storybook to its latest version
the 7