Fix for Issue #174 - pageAppeared Delegate Callback #177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#174
There is a bug in which tapping a page to advance does not call the delegate callback
pageAppeared
. This is because the tap IBAction sets the new_currentPageIndex
before thenotifyDelegateWithPreviousPage
gets called. This latter method has a check which fails when the currentPageIndex is updated before calling it.This PR resolves this bug by just making the tap IBAction scroll to the page index and not update the currentPageIndex. Then in the scrollDidEnd callback, we update new currentPageIndex already.
Note that in #174 , this bug still exists when one calls the
setCurrentPageIndex:
method. My recommendation is to not expose thesetCurrentPageIndex:
setter, and instead expose thescrollToPageForIndex:
method. Then, we only ever update the newcurrentPageIndex
property once, after the scrollView delegate callback is called.