Skip to content

Commit

Permalink
fix: wrong filter id for cellboard balancing
Browse files Browse the repository at this point in the history
  • Loading branch information
Tonidotpy committed Apr 11, 2024
1 parent b6ec58d commit 07dbd06
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions cellboard/Core/Src/can_comms.c
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ void can_init_with_filter() {
.FilterActivation = CAN_FILTER_ENABLE,
.FilterBank = 0,
.FilterFIFOAssignment = CAN_FILTER_FIFO0,
.FilterIdHigh = BMS_TOPIC_FILTER_BALANCING << 5,
.FilterIdLow = BMS_TOPIC_FILTER_BALANCING << 5,
.FilterIdHigh = BMS_SET_BALANCING_STATUS_FRAME_ID << 5,
.FilterIdLow = BMS_SET_BALANCING_STATUS_FRAME_ID << 5,
.FilterMaskIdHigh = BMS_TOPIC_MASK_BALANCING << 5,
.FilterMaskIdLow = BMS_TOPIC_MASK_BALANCING << 5,
.FilterMode = CAN_FILTERMODE_IDMASK,
Expand Down
2 changes: 1 addition & 1 deletion cellboard/STM32-for-VSCode.config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ cpu: -mcpu=cortex-m4
fpu: -mfpu=fpv4-sp-d16
floatAbi: -mfloat-abi=hard
ldscript: STM32L432KBUx_FLASH_shifted.ld # linker script
#ldscript: STM32L432KBUx_FLASH.ld # linker script
# ldscript: STM32L432KBUx_FLASH.ld # linker script

# Compiler definitions. The -D prefix for the compiler will be automatically added.
cDefinitions:
Expand Down
2 changes: 1 addition & 1 deletion cellboard/openocd.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

# Programmer, can be changed to several interfaces
# Standard will be the stlink interface as this is the standard for STM32 dev boards
source [find interface/stlink.cfg]
source [find interface/cmsis-dap.cfg]

# The target MCU. This should match your board
source [find target/stm32l4x.cfg]

0 comments on commit 07dbd06

Please sign in to comment.