-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add preliminary support for ghc-modi #54
base: master
Are you sure you want to change the base?
Conversation
Right now only the 'type' and 'info' functions are supported. ghc-modi's `make` is still somewhat buggy.
I'm using this, I really like it. |
is anything holding it back? |
What's the status on this? |
@eagletmt can you merge this ? it seems to be working just fine and is a massive improvement in usability. |
+1 |
FYI, both issues mentioned by the @int3 in his first comment have been solved. |
It would be nice if But otherwise 👍 |
I've been using this fork myself and it's a massive improvement. Anything we can do to bring it into master? |
I rebased this on top of current master and changed a few things. Most notably I unified handling of newlines/boundary and added support for multiple ghc-modi instances (one per package). It works for me with a rather large multipackage haskell codebase that uses stack. See #102 for my pull request. |
This enables the
check
andinfo
functions to useghc-modi
if it is available. This addresses part of #48.I had sketched an implementation for
make
as well, but it fails a lot ofghcmod-vim
's tests due to DanielG/ghc-mod#275, so it's been left out for now.Also, ghc-modi does not support spaces in filenames (DanielG/ghc-mod#295), so
check
andinfo
inherit this issue.The
g:ghcmod_should_use_ghc_modi
flag determines whether the plugin attempts to useghc-modi
.