Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Router is broken since laravel/framework 7.7.0 because newRoute() changed signature #17

Closed
pgrenaud opened this issue May 26, 2020 · 1 comment
Closed

Router is broken since laravel/framework 7.7.0 because newRoute() changed signature #17

pgrenaud opened this issue May 26, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@pgrenaud
Copy link
Contributor

Caused by laravel/framework#32416
@pgrenaud
Copy link
Contributor Author

Need to change this line https://github.com/eXolnet/laravel-translation/blob/master/src/Routing/Router.php#L107

@pgrenaud pgrenaud added the bug Something isn't working label May 26, 2020
@pgrenaud pgrenaud changed the title Router is broken since laravel/framework 7.13.0 because newRoute() changed signature Router is broken since laravel/framework 7.7.0 because newRoute() changed signature May 26, 2020
pgrenaud added a commit that referenced this issue May 26, 2020
@pgrenaud
Fix newRoute() Router method signature changed in laravel/framework 7…
ea528a7 
….7.0

Fix #17
pgrenaud added a commit that referenced this issue Jun 2, 2020
@pgrenaud
No need to restrict to 7.7.x, since you can make a protected method p…
2b716e4 
…ublic in child class

Ref #17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pgrenaud