-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes IndexError elmap #96
Conversation
@akhoubani This changes the ordering of elements as I understand. Did you double check with other Nek5000 setups that it works? |
An alternate solution could be to keep the ordering that we had earlier (since there maybe an obscure user which relies on that order) and create an new element map capped with |
I am unsure why |
If I remember correctly, the reason for ordering the elements with This is something I could add a test for. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
It could still fail if elmap
is not a permutation of 1..nel and doesn't contain zero but this is maybe not a problem in practice and it's complex to check.
Maybe use logger.warning()
instead of print()
too.
LGTM! |
Fixes #48