Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise exception not log #121

Merged
merged 5 commits into from
Oct 8, 2024
Merged

Raise exception not log #121

merged 5 commits into from
Oct 8, 2024

Conversation

ashwinvis
Copy link
Member

@ashwinvis ashwinvis commented Oct 8, 2024 •
edited
Loading

  • Convert logger.error into ValueError
  • Rely on native exceptions or use ValueError instead of logger.critical
  • Keep logger.error when within a loop
  • Rm unreachable code

Fixes #80 #39

@ashwinvis ashwinvis changed the title raise exception not log Raise exception not log Oct 8, 2024
@ashwinvis ashwinvis merged commit b25c2c8 into main Oct 8, 2024
10 checks passed
@ashwinvis ashwinvis deleted the raise-exception-not-log branch October 8, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use exceptions instead of C-style return values for errors
1 participant
@ashwinvis