-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[22463] Fix Discovery CLI Tool in Windows (No privileges) (backport #5493) #5509
Conversation
Cherry-pick of 2cdc2d9 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
@Mergifyio rebase |
* Refs #22463: Add test to check proper link between python and cpp files Signed-off-by: cferreiragonz <[email protected]> * Refs #22463: Remove .bat.in and call .exe from python Signed-off-by: cferreiragonz <[email protected]> * Refs #22463: Apply suggestions Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> (cherry picked from commit 2cdc2d9) # Conflicts: # tools/fastdds/discovery/parser.py
Signed-off-by: Miguel Company <[email protected]>
✅ Branch has been successfully rebased |
9521803
to
ec8e43d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
Description
When Fast DDS is compiled without admin privileges, no symlink is created to link to the
fast-discovery-server-1.0.1.exe
file. In this case, an alternative.bat
is created to call the tool. However, the.bat
file contains an error and fails to properly call the tool because it adds an unknown parameter as argument. To solve this, the.bat
file was removed and the.exe
file is called from the Python script directly. This gives more control over the tool as it does not bypass the Python script when compiling without admin privileges.@Mergifyio backport 3.1.x 3.0.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A New feature has been added to the
versions.md
file (if applicable).N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #5493 done by [Mergify](https://mergify.com).