Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21620] Fix load profiles TSAN issue (#3281) #5212

Closed
wants to merge 1 commit into from
Closed

[21620] Fix load profiles TSAN issue (#3281) #5212

wants to merge 1 commit into from

Conversation

roscan-tech
Copy link

@roscan-tech roscan-tech commented Sep 8, 2024 •
edited by JesusPoderoso
Loading

  • Add regression test

  • Fix load profiles TSAN issue

  • make test to wait to all discovery

  • uncrustify

Description

Edit: Source PR

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@jparisu @roscan-tech
Fix load profiles TSAN issue (eProsima#3281)
1769bba 
* Add regression test

Signed-off-by: jparisu <[email protected]>

* Fix load profiles TSAN issue

Signed-off-by: jparisu <[email protected]>

* make test to wait to all discovery

Signed-off-by: jparisu <[email protected]>

* uncrustify

Signed-off-by: jparisu <[email protected]>

---------

Signed-off-by: jparisu <[email protected]>
Signed-off-by: roscan-tech <[email protected]>
@JesusPoderoso JesusPoderoso added this to the v2.10.5 milestone Sep 10, 2024
@JesusPoderoso JesusPoderoso added the needs-review PR that is ready to be reviewed label Sep 10, 2024
@JesusPoderoso
Copy link
Contributor

Hi @roscan-tech thanks for your contribution.
The eProsima Team will review this PR in the following days and come back with some feedback.

@JesusPoderoso JesusPoderoso changed the title [Backport]Fix load profiles TSAN issue (#3281) [21620] Fix load profiles TSAN issue (#3281) Sep 10, 2024
@MiguelCompany
Copy link
Member

This is changing the size of a public object, and thus is an ABI break, so this backport cannot be accepted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-review PR that is ready to be reviewed
Projects
None yet
Milestone
v2.10.5
Development

Successfully merging this pull request may close these issues.
4 participants
@roscan-tech @JesusPoderoso @MiguelCompany @jparisu