-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21387] Fix windows CI and add vanilla build step in ubuntu CI #5095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
elianalf
approved these changes
Jul 23, 2024
LGTM with green CI Fast DDS Python is failing because there is a branch with the same name. |
JesusPoderoso
added
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
and removed
ci-pending
PR which CI is running
labels
Jul 23, 2024
@Mergifyio backport 2.10.x 2.6.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
* Refs #21387: Fix windows CI Signed-off-by: JesusPoderoso <[email protected]> * Refs #21387: Add vanilla build in ubuntu CI Signed-off-by: JesusPoderoso <[email protected]> --------- Signed-off-by: JesusPoderoso <[email protected]> (cherry picked from commit 55ca0aa)
mergify bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
* Refs #21387: Fix windows CI Signed-off-by: JesusPoderoso <[email protected]> * Refs #21387: Add vanilla build in ubuntu CI Signed-off-by: JesusPoderoso <[email protected]> --------- Signed-off-by: JesusPoderoso <[email protected]> (cherry picked from commit 55ca0aa) # Conflicts: # .github/workflows/reusable-ubuntu-ci.yml # .github/workflows/reusable-windows-ci.yml
This was referenced Jul 23, 2024
JesusPoderoso
added a commit
that referenced
this pull request
Jul 23, 2024
* Refs #21387: Fix windows CI Signed-off-by: JesusPoderoso <[email protected]> * Refs #21387: Add vanilla build in ubuntu CI Signed-off-by: JesusPoderoso <[email protected]> --------- Signed-off-by: JesusPoderoso <[email protected]> (cherry picked from commit 55ca0aa)
MiguelCompany
pushed a commit
that referenced
this pull request
Jul 23, 2024
* Refs #21387: Fix windows CI Signed-off-by: JesusPoderoso <[email protected]> * Refs #21387: Add vanilla build in ubuntu CI Signed-off-by: JesusPoderoso <[email protected]> --------- Signed-off-by: JesusPoderoso <[email protected]> (cherry picked from commit 55ca0aa) Co-authored-by: Jesús Poderoso <[email protected]>
MiguelCompany
pushed a commit
that referenced
this pull request
Jul 23, 2024
* Refs #21387: Fix windows CI Signed-off-by: JesusPoderoso <[email protected]> * Refs #21387: Add vanilla build in ubuntu CI Signed-off-by: JesusPoderoso <[email protected]> --------- Signed-off-by: JesusPoderoso <[email protected]> (cherry picked from commit 55ca0aa) Co-authored-by: Jesús Poderoso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the windows CI that was using a removed eProsima-CI action, and includes a vanilla build job in ubuntu CI.
As part of the CI, it is backported to 2.6.x
@Mergifyio backport 2.10.x 2.6.x
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist