Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21387] Fix windows CI and add vanilla build step in ubuntu CI #5095

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Jul 22, 2024

Description

This PR fixes the windows CI that was using a removed eProsima-CI action, and includes a vanilla build job in ubuntu CI.
As part of the CI, it is backported to 2.6.x

@Mergifyio backport 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added this to the v2.14.4 milestone Jul 22, 2024
@JesusPoderoso JesusPoderoso requested a review from elianalf July 22, 2024 14:42
@JesusPoderoso JesusPoderoso self-assigned this Jul 22, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 22, 2024
@elianalf
Copy link
Contributor

elianalf commented Jul 23, 2024

LGTM with green CI Fast DDS Python is failing because there is a branch with the same name.

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jul 23, 2024
@JesusPoderoso
Copy link
Contributor Author

@Mergifyio backport 2.10.x 2.6.x

Copy link
Contributor

mergify bot commented Jul 23, 2024

backport 2.10.x 2.6.x

✅ Backports have been created

@MiguelCompany MiguelCompany merged commit 55ca0aa into 2.14.x Jul 23, 2024
18 of 20 checks passed
@MiguelCompany MiguelCompany deleted the hotfix/windows_ci branch July 23, 2024 08:56
mergify bot pushed a commit that referenced this pull request Jul 23, 2024
* Refs #21387: Fix windows CI

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #21387: Add vanilla build in ubuntu CI

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit 55ca0aa)
mergify bot pushed a commit that referenced this pull request Jul 23, 2024
* Refs #21387: Fix windows CI

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #21387: Add vanilla build in ubuntu CI

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit 55ca0aa)

# Conflicts:
#	.github/workflows/reusable-ubuntu-ci.yml
#	.github/workflows/reusable-windows-ci.yml
JesusPoderoso added a commit that referenced this pull request Jul 23, 2024
* Refs #21387: Fix windows CI

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #21387: Add vanilla build in ubuntu CI

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit 55ca0aa)
MiguelCompany pushed a commit that referenced this pull request Jul 23, 2024
* Refs #21387: Fix windows CI

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #21387: Add vanilla build in ubuntu CI

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit 55ca0aa)

Co-authored-by: Jesús Poderoso <[email protected]>
MiguelCompany pushed a commit that referenced this pull request Jul 23, 2024
* Refs #21387: Fix windows CI

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #21387: Add vanilla build in ubuntu CI

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit 55ca0aa)

Co-authored-by: Jesús Poderoso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-to-merge ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants