Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21267] Add Ubuntu weekly ci (backport #5038) #5054

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 11, 2024

Description

This PR addresses the following points related to the github CI:

  • Change windows reusable ci to use new merge meta files eProsima CI action
  • Add weekly ubuntu CI to test 2.x branches with CDR 1.1.x
  • move the if (!skip-ci) inside the reusable workflows (as done in other repos with the run-build input), but keep the if (!conflicts) in the PR workflow so the GitHub CI requirement is not satisfied if skipped by conflicts.
  • Refactor ubuntu ci - python build job:
    build packages-select fastdds_python package

@Mergifyio backport 2.14.x 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • The code follows the style guidelines of this project.

  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A Any new/modified methods have been properly documented using Doxygen.

  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.

  • N/A Changes are API compatible.

  • N/A New feature has been added to the versions.md file (if applicable).

  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #5038 done by [Mergify](https://mergify.com).

Copy link
Contributor Author

mergify bot commented Jul 11, 2024

Cherry-pick of e6773fb has failed:

On branch mergify/bp/2.14.x/pr-5038
Your branch is up to date with 'origin/2.14.x'.

You are currently cherry-picking commit e6773fb0b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/workflows/ubuntu-ci.yml

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   .github/workflows/nightly-ubuntu-ci.yml
	both modified:   .github/workflows/reusable-ubuntu-ci.yml
	both modified:   .github/workflows/reusable-windows-ci.yml
	deleted by us:   .github/workflows/weekly-ubuntu-ci.yml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts Backport PR wich git cherry pick failed label Jul 11, 2024
@mergify mergify bot mentioned this pull request Jul 11, 2024
8 tasks
@JesusPoderoso JesusPoderoso added this to the v2.14.3 milestone Jul 11, 2024
@JesusPoderoso JesusPoderoso force-pushed the mergify/bp/2.14.x/pr-5038 branch from 2384639 to 2b3f7a9 Compare July 11, 2024 08:13
@JesusPoderoso JesusPoderoso removed the conflicts Backport PR wich git cherry pick failed label Jul 11, 2024
@JesusPoderoso JesusPoderoso self-requested a review July 11, 2024 08:13
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 11, 2024
JesusPoderoso
JesusPoderoso previously approved these changes Jul 11, 2024
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI
(check build python step does not build fastdds, cancelling remain jobs)

* Refs #21267: Add weekly ubuntu CI to test 2.x branches with CDR 1.1.x

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: Change windows reusable ci to use new merge meta files eProsima CI action

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: move the !(skip_ci) inside the reusable workflows

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: compile fastdds_python package only

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: Apply Jesus suggestions

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit e6773fb)
@JesusPoderoso JesusPoderoso force-pushed the mergify/bp/2.14.x/pr-5038 branch from 2b3f7a9 to e418b5c Compare July 11, 2024 08:56
@JesusPoderoso JesusPoderoso self-requested a review July 11, 2024 08:56
@EduPonz EduPonz modified the milestones: v2.14.3 - Frozen, v2.14.4 Jul 11, 2024
@EduPonz EduPonz merged commit 064ce70 into 2.14.x Jul 15, 2024
12 of 18 checks passed
@EduPonz EduPonz deleted the mergify/bp/2.14.x/pr-5038 branch July 15, 2024 04:58
@EduPonz
Copy link

EduPonz commented Jul 15, 2024

@Mergifyio backport 2.6.x

Copy link
Contributor Author

mergify bot commented Jul 15, 2024

backport 2.6.x

✅ Backports have been created

mergify bot added a commit that referenced this pull request Jul 15, 2024
* Refs #21267: Add weekly ubuntu CI to test 2.x branches with CDR 1.1.x

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: Change windows reusable ci to use new merge meta files eProsima CI action

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: move the !(skip_ci) inside the reusable workflows

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: compile fastdds_python package only

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: Apply Jesus suggestions

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit e6773fb)

Co-authored-by: Mario Domínguez López <[email protected]>
(cherry picked from commit 064ce70)
JesusPoderoso pushed a commit that referenced this pull request Aug 7, 2024
* Refs #21267: Add weekly ubuntu CI to test 2.x branches with CDR 1.1.x

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: Change windows reusable ci to use new merge meta files eProsima CI action

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: move the !(skip_ci) inside the reusable workflows

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: compile fastdds_python package only

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: Apply Jesus suggestions

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit e6773fb)

Co-authored-by: Mario Domínguez López <[email protected]>
(cherry picked from commit 064ce70)
juanlofer-eprosima pushed a commit that referenced this pull request Aug 8, 2024
* Add Ubuntu weekly ci (#5038) (#5054)

* Refs #21267: Add weekly ubuntu CI to test 2.x branches with CDR 1.1.x

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: Change windows reusable ci to use new merge meta files eProsima CI action

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: move the !(skip_ci) inside the reusable workflows

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: compile fastdds_python package only

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: Apply Jesus suggestions

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit e6773fb)

Co-authored-by: Mario Domínguez López <[email protected]>
(cherry picked from commit 064ce70)

* Refs #21267: Add missing parameters in the workflow

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: JesusPoderoso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants