Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21158] CI - Improve CI inputs #4972

Closed
wants to merge 6 commits into from

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Jun 20, 2024

Description

This PR performs the following improvements in this project CI:

  • Set build and test conditions as reusable workflow inputs, so 'if's and labels are only considered in the pull request workflow, making reusable-workflows pull request event agnostic

This PR is on top of (and must be merged before):

Important: Backports must remove nightly workflows

@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added the skip-ci Automatically pass CI label Jun 20, 2024
@JesusPoderoso JesusPoderoso added this to the v3.0.0 milestone Jun 20, 2024
@JesusPoderoso JesusPoderoso self-assigned this Jun 20, 2024
@JesusPoderoso JesusPoderoso changed the base branch from master to hotfix/ci/avoid_ccache June 20, 2024 08:27
@JesusPoderoso JesusPoderoso force-pushed the hotfix/ci/avoid_ccache branch from ee36ef3 to 2602726 Compare June 20, 2024 08:28
@JesusPoderoso JesusPoderoso force-pushed the hotfix/ci/inputs_improvements branch from 40f224e to 138fcc0 Compare June 20, 2024 08:52
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 20, 2024
@JesusPoderoso JesusPoderoso removed the ci-pending PR which CI is running label Jun 20, 2024
Base automatically changed from hotfix/ci/avoid_ccache to master June 20, 2024 10:19
@JesusPoderoso JesusPoderoso requested review from richiprosima and removed request for richiprosima June 20, 2024 13:32
@JesusPoderoso JesusPoderoso force-pushed the hotfix/ci/inputs_improvements branch from 75f9ce5 to 398c7f8 Compare June 20, 2024 13:33
@JesusPoderoso JesusPoderoso requested review from richiprosima and removed request for richiprosima June 20, 2024 13:33
@JesusPoderoso JesusPoderoso force-pushed the hotfix/ci/inputs_improvements branch from 398c7f8 to 5b45f0d Compare June 20, 2024 13:35
@JesusPoderoso JesusPoderoso requested review from richiprosima and removed request for richiprosima June 20, 2024 13:35
@JesusPoderoso JesusPoderoso force-pushed the hotfix/ci/inputs_improvements branch from 5b45f0d to 20c61f9 Compare June 20, 2024 13:41
@JesusPoderoso JesusPoderoso requested review from richiprosima and removed request for richiprosima June 20, 2024 13:41
@JesusPoderoso JesusPoderoso force-pushed the hotfix/ci/inputs_improvements branch from 20c61f9 to 09b6cd9 Compare June 20, 2024 13:46
@JesusPoderoso JesusPoderoso requested review from richiprosima and removed request for richiprosima June 20, 2024 13:46
@JesusPoderoso JesusPoderoso force-pushed the hotfix/ci/inputs_improvements branch from 09b6cd9 to 7842256 Compare June 20, 2024 13:47
@JesusPoderoso JesusPoderoso requested review from richiprosima and removed request for richiprosima June 20, 2024 13:47
@JesusPoderoso JesusPoderoso added no-test Skip CI tests if PR marked with this label and removed skip-ci Automatically pass CI labels Jun 20, 2024
@JesusPoderoso JesusPoderoso removed the request for review from richiprosima June 20, 2024 13:47
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 20, 2024
@JesusPoderoso JesusPoderoso requested review from richiprosima and removed request for richiprosima June 24, 2024 08:12
@JesusPoderoso JesusPoderoso force-pushed the hotfix/ci/inputs_improvements branch from 6114bb7 to 4fe2b13 Compare June 24, 2024 08:15
@JesusPoderoso JesusPoderoso requested review from richiprosima and removed request for richiprosima June 24, 2024 08:16
@JesusPoderoso JesusPoderoso added to-do and removed ci-pending PR which CI is running labels Jun 26, 2024
@JesusPoderoso JesusPoderoso marked this pull request as draft July 4, 2024 06:21
@EduPonz EduPonz closed this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-test Skip CI tests if PR marked with this label to-do
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants