Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21130] Migrate ResourceManagement to rtps attributes API #4962

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Jun 18, 2024

Description

This PR migrates the ResouceManagement file from include/fastdds/rtps/resources/ to include/fastdds/rtps/attributes/.
This is part of a set of migrations and refactors related to the new mayor version v3.0.0.

Related python PR:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • ❌ Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • ❌ Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added this to the v3.0.0 milestone Jun 18, 2024
@JesusPoderoso JesusPoderoso self-assigned this Jun 18, 2024
@JesusPoderoso JesusPoderoso requested a review from EduPonz June 18, 2024 09:29
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 18, 2024
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is going to need one python counterpart

include/fastdds/rtps/attributes/ResourceManagement.h Outdated Show resolved Hide resolved
…date guards and .hpp format

Signed-off-by: JesusPoderoso <[email protected]>
EduPonz
EduPonz previously approved these changes Jun 18, 2024
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

Signed-off-by: JesusPoderoso <[email protected]>
@JesusPoderoso JesusPoderoso added skip-ci Automatically pass CI and removed versions-pending ci-pending PR which CI is running labels Jun 18, 2024
@JesusPoderoso JesusPoderoso requested a review from EduPonz June 18, 2024 14:29
@EduPonz EduPonz merged commit 5cc3dc3 into master Jun 18, 2024
7 checks passed
@EduPonz EduPonz deleted the feature/21130 branch June 18, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-ci Automatically pass CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants