Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21181] Fix parse XML dynamic type fuzzer issue #4961

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Jun 18, 2024

Description

This PR fixes the 69667 ClusterFuzz-External issue.

Note: changes are not backport compatible nor API compatible because have been caused by the Dynamic Types refactor, which is not.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • ❌ Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • ❌ Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added this to the v3.0.0 milestone Jun 18, 2024
@JesusPoderoso JesusPoderoso self-assigned this Jun 18, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 18, 2024
@JesusPoderoso JesusPoderoso requested review from Mario-DL and removed request for richiprosima June 18, 2024 12:30
src/cpp/xmlparser/XMLDynamicParser.cpp Outdated Show resolved Hide resolved
@JesusPoderoso JesusPoderoso requested a review from Mario-DL June 18, 2024 15:15
@JesusPoderoso JesusPoderoso requested review from Mario-DL and removed request for Mario-DL June 19, 2024 06:20
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mario-DL Mario-DL added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jun 19, 2024
@EduPonz EduPonz merged commit b52ae00 into master Jun 19, 2024
16 of 17 checks passed
@EduPonz EduPonz deleted the hotfix/21181 branch June 19, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants