Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18966] Refactor of regenerate_port. #3640

Merged
merged 1 commit into from
Jul 11, 2023
Merged

[18966] Refactor of regenerate_port. #3640

merged 1 commit into from
Jul 11, 2023

Conversation

jsan-rt
Copy link
Contributor

@jsan-rt jsan-rt commented Jun 29, 2023 •
edited by JesusPoderoso
Loading

Description

Small refactor to the way SHM ports are regenerated preventing extra shared pointers from being created.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • [NA] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • [NA] Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • [NA] New feature has been added to the versions.md file (if applicable).
  • [NA] New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EduPonz EduPonz added this to the v2.11.1 milestone Jul 6, 2023
@jsan-rt
Copy link
Contributor Author

jsan-rt commented Jul 6, 2023

@richiprosima please test mac

@jsan-rt
Copy link
Contributor Author

jsan-rt commented Jul 6, 2023

@richiprosima please test windows

@jsan-rt jsan-rt added the ci-pending PR which CI is running label Jul 6, 2023
@jsan-rt
Copy link
Contributor Author

jsan-rt commented Jul 6, 2023

Successful Mac test here

@jsan-rt
Copy link
Contributor Author

jsan-rt commented Jul 6, 2023

@Mergifyio backport 2.6.x 2.9.x 2.10.x

@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2023 •
edited
Loading

backport 2.6.x 2.9.x 2.10.x

✅ Backports have been created

@jsan-rt
Copy link
Contributor Author

jsan-rt commented Jul 7, 2023

@richiprosima please test windows

@jsan-rt jsan-rt added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jul 7, 2023
@jsan-rt
Copy link
Contributor Author

jsan-rt commented Jul 7, 2023

Test failures are unrelated

@JLBuenoLopez JLBuenoLopez removed the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Jul 10, 2023
JLBuenoLopez
JLBuenoLopez approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JesusPoderoso JesusPoderoso added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Jul 11, 2023
@EduPonz EduPonz merged commit e8fb3ec into master Jul 11, 2023
@EduPonz EduPonz deleted the bugfix/shm/improve_port_regeneration branch July 11, 2023 18:54
mergify bot pushed a commit that referenced this pull request Jul 11, 2023
@jsan-rt @mergify
Refactor of regenerate_port. (#3640)
c6186f4 
Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
(cherry picked from commit e8fb3ec)
@mergify mergify bot mentioned this pull request Jul 11, 2023
Merged
mergify bot pushed a commit that referenced this pull request Jul 11, 2023
@jsan-rt @mergify
Refactor of regenerate_port. (#3640)
8f6d627 
Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
(cherry picked from commit e8fb3ec)
mergify bot pushed a commit that referenced this pull request Jul 11, 2023
@jsan-rt @mergify
Refactor of regenerate_port. (#3640)
9b4b62c 
Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
(cherry picked from commit e8fb3ec)
This was referenced Jul 11, 2023
Merged
Merged
This was referenced Jul 20, 2023
Closed
Closed
EduPonz pushed a commit that referenced this pull request Aug 8, 2023
@mergify @jsan-rt
Refactor of regenerate_port (#3640) (#3697)
7184af1 
Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
(cherry picked from commit e8fb3ec)

Co-authored-by: jsantiago-eProsima <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLBuenoLopez JLBuenoLopez JLBuenoLopez approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.11.1
Development

Successfully merging this pull request may close these issues.
5 participants
@jsan-rt @JLBuenoLopez @EduPonz @JesusPoderoso @MiguelCompany